From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbbCBHOx (ORCPT ); Mon, 2 Mar 2015 02:14:53 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33860 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbbCBHOv (ORCPT ); Mon, 2 Mar 2015 02:14:51 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee691-f79b86d000004a5a-9c-54f40de07ad1 Content-transfer-encoding: 8BIT Message-id: <54F40DDF.8070708@samsung.com> Date: Mon, 02 Mar 2015 16:14:39 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 To: Jacek Anaszewski Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, cooloney@gmail.com, rpurdie@rpsys.net, treding@nvidia.com, p.zabel@pengutronix.de, andrew@lunn.ch, gregkh@linuxfoundation.org, florian.vaussard@epfl.ch, arno@natisbad.org, kuninori.morimoto.gx@renesas.com, hytszk@gmail.com, antonynpavlov@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Sakari Ailus , sw0312.kim@samsung.com, ideal.song@samsung.com Subject: Re: [PATCH 0/3] Add ktd2692 Flash LED driver References: <1424998891-25591-1-git-send-email-ingi2.kim@samsung.com> <54F02DF5.1000706@samsung.com> In-reply-to: <54F02DF5.1000706@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUySURiGd3hfXpBFnSjrpCuXW7pJmSnYaX1u9eO02qpl9vEjI3rTSpRA M/80+nCVDoWwNJeAOlEJs7FaQV+I5ty0zLRiK9CtzIXWVhrTXBZCrf5d230/z3Pf28OnRBZu FP9YTh6rypFlxzIC2jZfolwxKBxPS2q6noR7vG4Kl0x/5uIeVzcHP3XoOdjU/pyLu/2lAJeN 1nDx+boWBtsvNAPs/DkA8HN/E8DaV8MA+9ucAPc5bzD47ugtgOvf9HKw19dJY11FM42LHrXz 8APnUHDVkyYGVxo+Mfjt1OxNC4nNaAOkr1TLIZaimxRxVHl5pKlhnCFt32toYrdeZsiTahuP OO6PcUj1vfc8oj3/hSFlP5NIoFtPk4emCS4pvWMFZMy+ZCc8IFh3hM0+dopVrdxwSJDlNxuA clB4espj4WqATVAMIvgISpCu30yHeQF64WthioGAL4L1APW39VF/Tbdvf6HCQi1AL1ytYEYQ wrlowuALTvP5FIxB7S9PhDEelZcrwvYRgKy1v6iwPQFpDBMhpuEyFLhSxplhBsYhT2NNiCPh PmTqGAl55sOVSKMpBTOLKGihkal8IHR3HpSid0+LQ6lF8Ci61HOWO8MRUIxKDHWhBggaIpDH 2kiHr0EUMLhDQRFcjOyuP8UWodZGD60DC6r+q1P1r07VvzpmQFlBJKuUK9WHM1XSRLVMoc7P yUyU5yrsIPg+XdMf9ffBgGutG0A+iJ0lNBvH0kRc2Sl1ocINpMEMeioqUp4b/LicvIxVKanJ WCqRpiSvXpMau1C4PHpytwhmyvLYEyyrZFUZqvxsVu0GHH5ElAbIBd7s9OiLj3+Ix6fEKdNb 09Vd1Z7tSbeifWsL3pYUVlSYh+PP8HaUna3Ud+q81+OpO8f377lKMj5ska5PDDQEREvxnL1f C7rojrbN2sqo15NTkpT8Zm1uyTef0eSitr28Nrtj6GBzIcWI+3vRoNFoercr7lnLxpOGmAsq keNcLK3Okq1KoFRq2W+NmzbROQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA2WSe0hTURzHObt316u4OE2tg1HJjUqslfN5DLWgkBMVWK6QoOw2b1N0U3a1 MvxjPanFnDajGL41yzXzUVZaYfmIHpKmRVH5AHuQliSm2MNqm1hR568P53y/3/M9hx9LyT9J fdlkXYag1/GpHONBP/wxCBUDss+qwJrvi3BnbwuFT/74KMWdtzskuL0xT4KL2x5JccdQDsDm D6VSfLi8hsH1R6oBbprqB/jRUBXApqfvAB5qbQK4p6mAwQ0fLgF87tljCe7tu0fj3DPVND56 q80N32h644hqrmLwWct7Br/8NmvNXGIvsgPSk2OSkMqjFynSaO11I1XnPzOkdbyUJvW2Ewxp LrS7kcbrYxJSeG3QjZgOjzDEPBVIJjryaHKzeFJKcq7YABmrXxALtxtAZJLAJwp6P0GnTktM 1mmiuA1xCWsTQsMClQplBA7n/HS8Voji1m2MVcQkpzo+g/Pby6dmOrZieVHkVkb/n7BVFaPA M8Z4xSbVlt+eoMB/1i47SBoqsYD0Adn+b88rpQZg9zACdxbBEFRbO0JN8xzU1VfDGIEHK4dl AHXdvgOcBzI4G01a+mgjYFkKLkRt3SnTuBTl52un5cMA2cp+UtPyAGSwTLqYhovRxCmzxMkM XIKeXyh1sQ+MR8V3h10ab7gSGQw5wBlEwUoaFef3u+71gqHoVbuRdrIc7kHHOw9KnewOl6GT lnImF0DrX/Wsf+pZ/9QrAZQN+Ajp6nRxt0arXCHyWjFTp1mhTtPWA9e0vfW9DqoMuAVAFnCe MlIwppJL+b1ilrYFIJbivGVejmGUyxL5rAOCPi1Bn5kqiC0g1PG4PMrXR53mmF1dRoIyOCQs KCIoXImDgsO5uTJu9TGVHGr4DCFFENIF/YxPwrr7GsCONdHvts0fZGMqGuwpaN0uzc0X/u4V X59YswzlbaENL01lId2RwGzzvBGVXTB+ZIyJFPyX+8SXzG44FFayalbRgxeF+zKy6woXXo03 m0c3D2h2vqnLHVbPm2/vAGG9o/dNzXfKH5rWr19tmwq+jF/FBTd+2Wk+/bqiq+7K7jnVxliO FpN4ZQClF/lfhH7su4MDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacek On 2015년 02월 27일 17:42, Jacek Anaszewski wrote: > Hi Ingi, > > On 02/27/2015 02:01 AM, Ingi Kim wrote: >> This patch supports KTD2692 flash LED driver >> >> Ingi Kim (3): >> of: Add vendor prefix for Kinetic technologies >> leds: ktd2692: add device tree bindings for ktd2692 >> leds: Add ktd2692 flash LED driver >> >> .../devicetree/bindings/leds/leds-ktd2692.txt | 19 ++ >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> drivers/leds/Kconfig | 8 + >> drivers/leds/Makefile | 1 + >> drivers/leds/leds-ktd2692.c | 245 ++++++++++++++++++++ >> 5 files changed, 274 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> create mode 100644 drivers/leds/leds-ktd2692.c >> > > In your device tree binding documentation there is torch-gpio mentioned, > but you seem not to use it in the driver. > > We have already LED Flash class (/drivers/leds/led-class-flash.c) for > this type of devices, which handles both torch and flash modes > (flash_strobe sysfs attribute is provided for strobing the flash). > > The reference drivers using LED Flash class are still pending [1], but I > think that at least leds-aat1290 driver is almost ready for merging. > It controls very similar device to yours. > > Another advantage of using LED Flash class is that it has been designed > to be compatible with Video for Linux 2 subsystem, which will allow for registering LED Flash class devices as a V4L2 sub-devices. > > Adding Sakari. > Ok, I'll check LED Flash class, and add torch-gpio Thanks, Adding Seung-woo Kim and Inha Song