From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbbCBHmn (ORCPT ); Mon, 2 Mar 2015 02:42:43 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:38611 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbbCBHmm (ORCPT ); Mon, 2 Mar 2015 02:42:42 -0500 Message-ID: <54F4146A.1090103@linaro.org> Date: Mon, 02 Mar 2015 15:42:34 +0800 From: zhangfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Axel Lin , Kishon Vijay Abraham I CC: Jiancheng Xue , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: hix5hd2-sata: Convert to use devm_ioremap_resource References: <1425277920.21429.0.camel@phoenix> In-Reply-To: <1425277920.21429.0.camel@phoenix> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2015 02:32 PM, Axel Lin wrote: > devm_ioremap_resource() also has sanity check for the res argument which is > missed in current code. I remember we can not use devm_ioremap_resource here, because the memory region is shared with sata controller. And devm_request_mem_region would fail. So we directly use devm_ioremap here. > > Signed-off-by: Axel Lin > --- > drivers/phy/phy-hix5hd2-sata.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c > index 34915b4..798adcf 100644 > --- a/drivers/phy/phy-hix5hd2-sata.c > +++ b/drivers/phy/phy-hix5hd2-sata.c > @@ -147,9 +147,9 @@ static int hix5hd2_sata_phy_probe(struct platform_device *pdev) > return -ENOMEM; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->base = devm_ioremap(dev, res->start, resource_size(res)); > - if (!priv->base) > - return -ENOMEM; > + priv->base = devm_ioremap_resource(dev, res); > + if (IS_ERR(priv->base)) > + return PTR_ERR(priv->base); > > priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, > "hisilicon,peripheral-syscon"); >