From: Richard Weinberger <richard@nod.at>
To: Daeseok Youn <daeseok.youn@gmail.com>,
mfasheh@suse.com, akpm@linux-foundation.org
Cc: jlbec@evilplan.org, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error
Date: Mon, 02 Mar 2015 10:04:23 +0100 [thread overview]
Message-ID: <54F42797.1040908@nod.at> (raw)
In-Reply-To: <20150227234840.GA12922@devel.8.8.4.4>
Am 28.02.2015 um 00:48 schrieb Daeseok Youn:
> The use of 'status' in __ocfs2_add_entry() can return wrong
> status when some functions are failed.
>
> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed,
> that status is saved to 'status' but return variable is 'retval'
> which is saved 'success' status. In case of this, __ocfs2_add_entry()
> is failed but can be returned as 'success'.
>
> So replace 'status' with 'retval'.
As this patch is untested and the issue is theoretical I'm nervous.
But the final decision is up to ocfs2 maintainers.
Thanks,
//richard
next prev parent reply other threads:[~2015-03-02 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 23:48 [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error Daeseok Youn
2015-03-02 9:04 ` Richard Weinberger [this message]
2015-03-03 1:38 ` DaeSeok Youn
2015-03-05 9:36 ` DaeSeok Youn
2015-03-13 3:59 ` DaeSeok Youn
2015-03-13 8:15 ` Richard Weinberger
2015-03-19 6:24 ` [Ocfs2-devel] " Joseph Qi
2015-03-20 2:22 ` DaeSeok Youn
2015-03-19 22:23 ` Andrew Morton
2015-03-20 1:17 ` [Ocfs2-devel] " Joseph Qi
2015-03-24 6:17 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F42797.1040908@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=daeseok.youn@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).