From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbbCBLbT (ORCPT ); Mon, 2 Mar 2015 06:31:19 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:34829 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198AbbCBLbP (ORCPT ); Mon, 2 Mar 2015 06:31:15 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <06c0e6175e8042ae6125fc450782e2b8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54F449F6.90508@rock-chips.com> Date: Mon, 02 Mar 2015 19:31:02 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Paul Bolle CC: Liam Girdwood , djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Philipp Zabel , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Brian Austin , Bard Liao , Oder Chiou , Max Filippov , Axel Lin , Arnd Bergmann , Jyri Sarha , Sean Cross , Ben Zhang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Subject: Re: [PATCH v4 13/15] ASoC: codec/dw-hdmi-audio: add codec driver for dw hdmi audio References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425178760-2655-1-git-send-email-ykk@rock-chips.com> <1425287716.24292.87.camel@x220> In-Reply-To: <1425287716.24292.87.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015/3/2 17:15, Paul Bolle 写道: > On Sat, 2015-02-28 at 21:59 -0500, Yakir Yang wrote: >> --- /dev/null >> +++ b/sound/soc/codecs/dw-hdmi-audio.c >> @@ -0,0 +1,379 @@ >> +/* >> + * dw-hdmi-codec.c > Doesn't match the filename. Is this line needed? Thanks, this comment are good for read, and seems others codec driver also content this comment, so I think we can keep this comment. I will correct the file name it in next version. Thanks for you reply :) > >> + * DesignerWare ALSA SoC DAI driver for DW HDMI audio. >> + * Copyright (c) 2014, CORPORATION. All rights reserved. >> + * Authors: Yakir Yang >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program. If not, see .* >> + * >> + */ > This states that the license is plain GPL v2. > > (Missing empty line here.) Okay, thanks, correct it in next version. Thanks :) >> +#include > [...] > >> +MODULE_LICENSE("GPL"); > So you probably want > MODULE_LICENSE("GPL v2"); > > here. Okay, thanks, correct it in next version. Thanks :) Yakir Yang Best regards. > > Paul Bolle > > > >