From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754370AbbCBN6i (ORCPT ); Mon, 2 Mar 2015 08:58:38 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:33227 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753936AbbCBN6f (ORCPT ); Mon, 2 Mar 2015 08:58:35 -0500 Message-ID: <54F46C80.8050906@collabora.co.uk> Date: Mon, 02 Mar 2015 14:58:24 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: One Thousand Gnomes CC: Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Gwendal Grignou , Fengguang Wu , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] platform/chrome: cros_ec_lpc - Depend on X86 || COMPILE_TEST References: <1425015470-4846-1-git-send-email-javier.martinez@collabora.co.uk> <1425015470-4846-3-git-send-email-javier.martinez@collabora.co.uk> <20150302134542.1a269fce@lxorguk.ukuu.org.uk> In-Reply-To: <20150302134542.1a269fce@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alan, On 03/02/2015 02:45 PM, One Thousand Gnomes wrote: > On Fri, 27 Feb 2015 06:37:49 +0100 > Javier Martinez Canillas wrote: > >> The Low Pin Count bus was introduced by Intel and is only used >> in x86 computers > > The LPC bus is in all but name a slightly chopped down ISA bus. It is not > x86 specific any more, and indeed there are wishbone/LPC busses used on > all sorts of systems and processor types. > Thanks a lot for the clarification, I didn't know that. > The ChromeOS EC may well be X86 specific but if so please fix the commit > message accordingly. > I'll let the ChromiumOS folks to answer if EC connected through LPC will only be used in x86 Chromebooks and non-x86 Chromebooks will always use either SPI or I2C. Or if a non-x86 Chromebook with a EC connected through LPC may exist in the future. To know if I should either update the commit message or drop $subject, since after patch 1/3 the driver builds correctly in other architectures. > Alan > Best regards, Javier