Re: [PATCH v2 1/2] x86: mce: kexec: turn off MCE in kexec

Naoya Horiguchi
2015-02-27T12:46:23Z

Hi Prarit,

On Fri, Feb 27, 2015 at 06:09:52AM -0500, Prarit Bhargava wrote:
...
> > @@ -157,6 +160,11 @@ void native_machine_crash_shutdown(struct pt_regs *regs)
> > /* The kernel is broken so disable interrupts */
> > local_irq_disable();
> >
> > + /*
> > + * We can't expect MCE handling to work any more, so turn it off.
> > + */
> > + cpu_emergency_mce_disable();
>
> What if the system is actually having problems with MCE errors -- which are
> leading to system panics of some sort. Do you *really* want the system to
> continue on at that point?

Yes, when running the above code, the system doesn't run any business logic,
so no worry about consuming broken data caused by HW errors.
And what we really want to get is any kind of information to find out what
caused the 1st panic, which are likely to be contained in kdump data.
So I think it's justified to improve the success rate of kdump by continuing
the operation here.

Thanks,
Naoya Horiguchi