From: Suman Anna <s-anna@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations
Date: Mon, 2 Mar 2015 10:50:52 -0600 [thread overview]
Message-ID: <54F494EC.10406@ti.com> (raw)
In-Reply-To: <1425079588.2690.20.camel@perches.com>
On 02/27/2015 05:26 PM, Joe Perches wrote:
> On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
>> Fix couple of checkpatch warnings of the type,
>> "WARNING: Missing a blank line after declarations"
> []
>> diff --git a/drivers/remoteproc/ste_modem_rproc.c b/drivers/remoteproc/ste_modem_rproc.c
> []
>> @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
>> static int sproc_stop(struct rproc *rproc)
>> {
>> struct sproc *sproc = rproc->priv;
>> +
>> sproc_dbg(sproc, "stop ste-modem\n");
>
> You could probably delete this sproc_dbg
> statement too as it duplicates function tracing.
Thanks for the comment, I will leave that to be done in a different
cleanup patch.
regards
Suman
next prev parent reply other threads:[~2015-03-02 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 23:18 [PATCH 0/3] remoteproc checkpatch fixes Suman Anna
2015-02-27 23:18 ` [PATCH 1/3] remoteproc/ste: add blank lines after declarations Suman Anna
2015-02-27 23:26 ` Joe Perches
2015-03-02 16:50 ` Suman Anna [this message]
2015-02-27 23:18 ` [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch warning Suman Anna
2015-02-27 23:27 ` Joe Perches
2015-03-02 16:52 ` Suman Anna
2015-02-27 23:18 ` [PATCH 3/3] remoteproc: fix various checkpatch warnings Suman Anna
2015-05-02 8:16 ` [PATCH 0/3] remoteproc checkpatch fixes Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F494EC.10406@ti.com \
--to=s-anna@ti.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).