From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754284AbbCBQu5 (ORCPT ); Mon, 2 Mar 2015 11:50:57 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:51171 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbbCBQu4 (ORCPT ); Mon, 2 Mar 2015 11:50:56 -0500 Message-ID: <54F494EC.10406@ti.com> Date: Mon, 2 Mar 2015 10:50:52 -0600 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joe Perches CC: Ohad Ben-Cohen , Subject: Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations References: <1425079103-41695-1-git-send-email-s-anna@ti.com> <1425079103-41695-2-git-send-email-s-anna@ti.com> <1425079588.2690.20.camel@perches.com> In-Reply-To: <1425079588.2690.20.camel@perches.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27/2015 05:26 PM, Joe Perches wrote: > On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote: >> Fix couple of checkpatch warnings of the type, >> "WARNING: Missing a blank line after declarations" > [] >> diff --git a/drivers/remoteproc/ste_modem_rproc.c b/drivers/remoteproc/ste_modem_rproc.c > [] >> @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc) >> static int sproc_stop(struct rproc *rproc) >> { >> struct sproc *sproc = rproc->priv; >> + >> sproc_dbg(sproc, "stop ste-modem\n"); > > You could probably delete this sproc_dbg > statement too as it duplicates function tracing. Thanks for the comment, I will leave that to be done in a different cleanup patch. regards Suman