From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbbCBQw3 (ORCPT ); Mon, 2 Mar 2015 11:52:29 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:59332 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517AbbCBQw2 (ORCPT ); Mon, 2 Mar 2015 11:52:28 -0500 Message-ID: <54F49549.5090706@ti.com> Date: Mon, 2 Mar 2015 10:52:25 -0600 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joe Perches CC: Ohad Ben-Cohen , Subject: Re: [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch warning References: <1425079103-41695-1-git-send-email-s-anna@ti.com> <1425079103-41695-3-git-send-email-s-anna@ti.com> <1425079647.2690.21.camel@perches.com> In-Reply-To: <1425079647.2690.21.camel@perches.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27/2015 05:27 PM, Joe Perches wrote: > On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote: >> Fix the following checkpatch warning, >> WARNING: quoted string split across lines >> + "\n\t\tName of DSP firmware file in /lib/firmware" >> + " (if not specified defaults to 'rproc-dsp-fw')"); > [] >> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c > [] >> @@ -26,8 +26,7 @@ >> static char *da8xx_fw_name; >> module_param(da8xx_fw_name, charp, S_IRUGO); >> MODULE_PARM_DESC(da8xx_fw_name, >> - "\n\t\tName of DSP firmware file in /lib/firmware" >> - " (if not specified defaults to 'rproc-dsp-fw')"); >> + "\n\t\tName of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')"); > > There's probably no value in the leading "\n\t\t" Agreed. Ohad, Let me know if you want that in a different patch, otherwise, you can probably fix this up when applying. regards Suman