From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755498AbbCBQ5J (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 11:57:09 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52772 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751526AbbCBQ5G (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 11:57:06 -0500
Message-ID: <54F4965D.7000701@suse.de>
Date: Mon, 02 Mar 2015 17:57:01 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Organization: SUSE Linux GmbH
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Michael Mueller <mimu@linux.vnet.ibm.com>
CC: qemu-devel@nongnu.org, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        linux-s390@vger.kernel.org, kvm@vger.kernel.org,
        Gleb Natapov <gleb@kernel.org>, Alexander Graf <agraf@suse.de>,
        Eduardo Habkost <ehabkost@redhat.com>, linux-kernel@vger.kernel.org,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        "Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Alistair Francis <alistair.francis@xilinx.com>,
        Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine
 type none
References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com>	<1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com>	<54F46C41.3000201@suse.de> <20150302174352.3715f1e4@bee>
In-Reply-To: <20150302174352.3715f1e4@bee>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 02.03.2015 um 17:43 schrieb Michael Mueller:
> On Mon, 02 Mar 2015 14:57:21 +0100
> Andreas Färber <afaerber@suse.de> wrote:
> 
>>>  int configure_accelerator(MachineState *ms)
>>>  {
>>> -    const char *p;
>>> +    const char *p, *name;
>>>      char buf[10];
>>>      int ret;
>>>      bool accel_initialised = false;
>>>      bool init_failed = false;
>>>      AccelClass *acc = NULL;
>>> +    ObjectClass *oc;
>>> +    bool probe_mode = false;
>>>  
>>>      p = qemu_opt_get(qemu_get_machine_opts(), "accel");
>>>      if (p == NULL) {
>>> -        /* Use the default "accelerator", tcg */
>>> -        p = "tcg";
>>> +        oc = (ObjectClass *) MACHINE_GET_CLASS(current_machine);
>>> +        name = object_class_get_name(oc);
>>> +        probe_mode = !strcmp(name, "none" TYPE_MACHINE_SUFFIX);
>>> +        if (probe_mode) {
>>> +            /* Use these accelerators in probe mode, tcg should be last */
>>> +            p = probe_mode_accels;
>>> +        } else {
>>> +            /* Use the default "accelerator", tcg */
>>> +            p = "tcg";
>>> +        }
>>>      }  
>>
>> Can't we instead use an explicit ,accel=probe or ,accel=auto?
>> That would then obsolete the next patch.
> 
> How would you express the following with the accel=<pseudo-accel> approach?
> 
> -probe -machine s390-ccw,accel=kvm 
> 
> Using machine "none" as default with tcg as last accelerator initialized should not break
> anything.
> 
> -M none

Let me ask differently: What does -machine none or -M none have to do
with probing? It reads as if you are introducing two probe modes. Why do
you need both? If we have -probe, isn't that independent of which
machine we specify? Who is going to call either, with which respective goal?

I think that changing the semantics of an absent ,accel=foo parameter to
mean something else than its longtime default of tcg is a bad idea.

Have you testing qtest with it? Doesn't -qtest imply accel=qtest or is
that always passed explicitly?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)