From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755328AbbCBRId (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 12:08:33 -0500
Received: from lists.s-osg.org ([54.187.51.154]:59325 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753789AbbCBRIc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 12:08:32 -0500
Message-ID: <54F4990F.1030409@osg.samsung.com>
Date: Mon, 02 Mar 2015 10:08:31 -0700
From: Shuah Khan <shuahkh@osg.samsung.com>
Organization: Samsung Open Source Group
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: John Stultz <john.stultz@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
CC: Prarit Bhargava <prarit@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 01/19] selftests/timers: Cleanup Makefile to make it easier
 to add future tests
References: <1424903544-26855-1-git-send-email-john.stultz@linaro.org> <1424903544-26855-2-git-send-email-john.stultz@linaro.org>
In-Reply-To: <1424903544-26855-2-git-send-email-john.stultz@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/25/2015 03:32 PM, John Stultz wrote:
> Try to streamline the makefile so its easier to add timer/timekeeping
> tests.
> 
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Prarit Bhargava <prarit@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  tools/testing/selftests/timers/Makefile | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index eb2859f..90a37b3 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -1,8 +1,11 @@
> -all:
> -	gcc posix_timers.c -o posix_timers -lrt
> +CFLAGS += -O3 -Wl,-no-as-needed
> +LDFLAGS += -lrt -lpthread
> +bins = posix_timers
> +
> +all: ${bins}
>  
>  run_tests: all
>  	./posix_timers

Please add another target for running destructive
tests. You might have to classify tests so posix_timers
doesn't run all of them by default.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978