* [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag
@ 2015-03-02 13:35 Valentin Rothberg
2015-03-02 16:05 ` Tony Lindgren
2015-03-02 17:29 ` santosh shilimkar
0 siblings, 2 replies; 3+ messages in thread
From: Valentin Rothberg @ 2015-03-02 13:35 UTC (permalink / raw)
To: tony, ssantosh, linux-kernel; +Cc: Valentin Rothberg
The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
disabled") running IRQ handlers with interrupts enabled can cause stack
overflows when the interrupt line of the issuing device is still active.
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
drivers/bus/omap_l3_smx.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
index 597fdae..360a5c0 100644
--- a/drivers/bus/omap_l3_smx.c
+++ b/drivers/bus/omap_l3_smx.c
@@ -251,18 +251,16 @@ static int omap3_l3_probe(struct platform_device *pdev)
}
l3->debug_irq = platform_get_irq(pdev, 0);
- ret = request_irq(l3->debug_irq, omap3_l3_app_irq,
- IRQF_DISABLED | IRQF_TRIGGER_RISING,
- "l3-debug-irq", l3);
+ ret = request_irq(l3->debug_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING,
+ "l3-debug-irq", l3);
if (ret) {
dev_err(&pdev->dev, "couldn't request debug irq\n");
goto err1;
}
l3->app_irq = platform_get_irq(pdev, 1);
- ret = request_irq(l3->app_irq, omap3_l3_app_irq,
- IRQF_DISABLED | IRQF_TRIGGER_RISING,
- "l3-app-irq", l3);
+ ret = request_irq(l3->app_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING,
+ "l3-app-irq", l3);
if (ret) {
dev_err(&pdev->dev, "couldn't request app irq\n");
goto err2;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag
2015-03-02 13:35 [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag Valentin Rothberg
@ 2015-03-02 16:05 ` Tony Lindgren
2015-03-02 17:29 ` santosh shilimkar
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2015-03-02 16:05 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: ssantosh, linux-kernel
* Valentin Rothberg <Valentin.Rothberg@lip6.fr> [150302 05:39]:
> The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
> to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
> disabled") running IRQ handlers with interrupts enabled can cause stack
> overflows when the interrupt line of the issuing device is still active.
>
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Applying into omap-for-v4.1/l3 thanks.
Regards,
Tony
> ---
> drivers/bus/omap_l3_smx.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
> index 597fdae..360a5c0 100644
> --- a/drivers/bus/omap_l3_smx.c
> +++ b/drivers/bus/omap_l3_smx.c
> @@ -251,18 +251,16 @@ static int omap3_l3_probe(struct platform_device *pdev)
> }
>
> l3->debug_irq = platform_get_irq(pdev, 0);
> - ret = request_irq(l3->debug_irq, omap3_l3_app_irq,
> - IRQF_DISABLED | IRQF_TRIGGER_RISING,
> - "l3-debug-irq", l3);
> + ret = request_irq(l3->debug_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING,
> + "l3-debug-irq", l3);
> if (ret) {
> dev_err(&pdev->dev, "couldn't request debug irq\n");
> goto err1;
> }
>
> l3->app_irq = platform_get_irq(pdev, 1);
> - ret = request_irq(l3->app_irq, omap3_l3_app_irq,
> - IRQF_DISABLED | IRQF_TRIGGER_RISING,
> - "l3-app-irq", l3);
> + ret = request_irq(l3->app_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING,
> + "l3-app-irq", l3);
> if (ret) {
> dev_err(&pdev->dev, "couldn't request app irq\n");
> goto err2;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag
2015-03-02 13:35 [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-03-02 16:05 ` Tony Lindgren
@ 2015-03-02 17:29 ` santosh shilimkar
1 sibling, 0 replies; 3+ messages in thread
From: santosh shilimkar @ 2015-03-02 17:29 UTC (permalink / raw)
To: Valentin Rothberg, tony, ssantosh, linux-kernel
On 3/2/2015 5:35 AM, Valentin Rothberg wrote:
> The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According
> to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
> disabled") running IRQ handlers with interrupts enabled can cause stack
> overflows when the interrupt line of the issuing device is still active.
>
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-02 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02 13:35 [PATCH] omap_l3_smx.c: remove IRQF_DISABLED flag Valentin Rothberg
2015-03-02 16:05 ` Tony Lindgren
2015-03-02 17:29 ` santosh shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).