From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754837AbbCBTJ7 (ORCPT ); Mon, 2 Mar 2015 14:09:59 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:40988 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbbCBTJ4 (ORCPT ); Mon, 2 Mar 2015 14:09:56 -0500 X-IronPort-AV: E=Sophos;i="5.09,676,1418112000"; d="scan'208";a="58363728" Message-ID: <54F4B576.5030702@broadcom.com> Date: Mon, 2 Mar 2015 11:09:42 -0800 From: Arun Ramamurthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pawel Moll CC: Rob Herring , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , Dmitry Torokhov , "Anatol Pomazau" , Jonathan Richardson , Scott Branden , Ray Jui , "bcm-kernel-feedback-list@broadcom.com" Subject: Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC References: <1424898082-1522-1-git-send-email-arun.ramamurthy@broadcom.com> <1424898082-1522-3-git-send-email-arun.ramamurthy@broadcom.com> <1425312029.3092.1.camel@arm.com> In-Reply-To: <1425312029.3092.1.camel@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-03-02 08:00 AM, Pawel Moll wrote: > On Wed, 2015-02-25 at 21:01 +0000, Arun Ramamurthy wrote: >> Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC >> Also corrected documentation to make interrupts and interrupt-names >> optional as they are not required properties. > > You may not be aware of this fact, but its the "documentation" what > defines what properties are required... > Pawel, I was not aware of that. Since the driver code did not require the interrupts or interrupt-names bindings to load properly, I moved it out of the required properties. I can remove that change. Any other comments on this change? Thanks >> Reviewed-by: Ray Jui >> Reviewed-by: Scott Branden >> Signed-off-by: Arun Ramamurthy 0 >> --- >> .../devicetree/bindings/video/arm,pl11x.txt | 11 +-- >> drivers/video/fbdev/amba-clcd.c | 82 ++++++++++++++++++++++ >> include/linux/amba/clcd.h | 4 ++ >> 3 files changed, 89 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt >> index 2262cdb..7d19024 100644 >> --- a/Documentation/devicetree/bindings/video/arm,pl11x.txt >> +++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt >> @@ -10,14 +10,6 @@ Required properties: >> >> - reg: base address and size of the control registers block >> >> -- interrupt-names: either the single entry "combined" representing a >> - combined interrupt output (CLCDINTR), or the four entries >> - "mbe", "vcomp", "lnbu", "fuf" representing the individual >> - CLCDMBEINTR, CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR interrupts >> - >> -- interrupts: contains an interrupt specifier for each entry in >> - interrupt-names >> - >> - clock-names: should contain "clcdclk" and "apb_pclk" >> >> - clocks: contains phandle and clock specifier pairs for the entries > > So no, you can't do that. > > Pawel >