From: Joel Schopp <joel.schopp@amd.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@alien8.de>,
<linux-kernel@vger.kernel.org>,
David Kaplan <david.kaplan@amd.com>
Subject: Re: [PATCH v2 1/2] kvm: x86: make kvm_emulate_* consistant
Date: Mon, 2 Mar 2015 13:20:42 -0600 [thread overview]
Message-ID: <54F4B80A.5080103@amd.com> (raw)
In-Reply-To: <20150302190430.GC25123@potion.brq.redhat.com>
>> ---
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> @@ -4995,7 +4995,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu,
>> if (emulate_instruction(vcpu, 0) == EMULATE_DONE) {
>> if (vcpu->arch.halt_request) {
>> vcpu->arch.halt_request = 0;
>> - return kvm_emulate_halt(vcpu);
>> + return kvm_emulate_halt_noskip(vcpu);
> noskip is used without being declared ... it shouldn't compile.
I tested on AMD hardware, I thought I had turned on the Intel KVM module
as well, but it turns out I hadn't. Will fix in v3.
> *_noskip makes the usual case harder to undertand: we just want to halt
> the vcpu, so name it more directly ... like kvm_vcpu_halt()?
I like that better. Will make the change in v3.
next prev parent reply other threads:[~2015-03-02 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 18:04 [PATCH v2 0/2] Series short description Joel Schopp
2015-03-02 18:04 ` [PATCH v2 1/2] kvm: x86: make kvm_emulate_* consistant Joel Schopp
2015-03-02 19:04 ` Radim Krčmář
2015-03-02 19:20 ` Joel Schopp [this message]
2015-03-02 18:04 ` [PATCH v2 2/2] x86: svm: make wbinvd faster Joel Schopp
2015-03-02 19:05 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4B80A.5080103@amd.com \
--to=joel.schopp@amd.com \
--cc=bp@alien8.de \
--cc=david.kaplan@amd.com \
--cc=gleb@kernel.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).