From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbbCBTVN (ORCPT ); Mon, 2 Mar 2015 14:21:13 -0500 Received: from mail-by2on0145.outbound.protection.outlook.com ([207.46.100.145]:9121 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753590AbbCBTVL (ORCPT ); Mon, 2 Mar 2015 14:21:11 -0500 X-WSS-ID: 0NKLN2L-08-5IK-02 X-M-MSG: Message-ID: <54F4B80A.5080103@amd.com> Date: Mon, 2 Mar 2015 13:20:42 -0600 From: Joel Schopp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: Gleb Natapov , Paolo Bonzini , , Joerg Roedel , Borislav Petkov , , David Kaplan Subject: Re: [PATCH v2 1/2] kvm: x86: make kvm_emulate_* consistant References: <20150302180030.25137.83460.stgit@joelvmguard2.amd.com> <20150302180439.25137.12334.stgit@joelvmguard2.amd.com> <20150302190430.GC25123@potion.brq.redhat.com> In-Reply-To: <20150302190430.GC25123@potion.brq.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Joel.Schopp@amd.com; 8bytes.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(199003)(189002)(83506001)(33656002)(87266999)(54356999)(86362001)(87936001)(46102003)(80316001)(50466002)(23676002)(77156002)(50986999)(65806001)(62966003)(92566002)(106466001)(110136001)(2950100001)(36756003)(76176999)(101416001)(77096005)(105586002)(65956001)(47776003);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB476;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB476; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BY2PR02MB476;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB476; X-Forefront-PRVS: 0503FF9A3E X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2015 19:20:54.3845 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB476 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> --- >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> @@ -4995,7 +4995,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu, >> if (emulate_instruction(vcpu, 0) == EMULATE_DONE) { >> if (vcpu->arch.halt_request) { >> vcpu->arch.halt_request = 0; >> - return kvm_emulate_halt(vcpu); >> + return kvm_emulate_halt_noskip(vcpu); > noskip is used without being declared ... it shouldn't compile. I tested on AMD hardware, I thought I had turned on the Intel KVM module as well, but it turns out I hadn't. Will fix in v3. > *_noskip makes the usual case harder to undertand: we just want to halt > the vcpu, so name it more directly ... like kvm_vcpu_halt()? I like that better. Will make the change in v3.