From: Lars-Peter Clausen <lars@metafoo.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: virt-dma: fix completion list manipulation
Date: Mon, 02 Mar 2015 22:29:21 +0100 [thread overview]
Message-ID: <54F4D631.6020605@metafoo.de> (raw)
In-Reply-To: <1425331196-7895-1-git-send-email-robert.jarzmik@free.fr>
On 03/02/2015 10:19 PM, Robert Jarzmik wrote:
> diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
> index 3772032..2a3da22 100644
> --- a/drivers/dma/virt-dma.h
> +++ b/drivers/dma/virt-dma.h
> @@ -91,7 +91,7 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
> dma_cookie_complete(&vd->tx);
> dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
> vd, cookie);
> - list_add_tail(&vd->node, &vc->desc_completed);
> + list_move_tail(&vd->node, &vc->desc_completed);
That will break all drivers which handle this currently correctly and remove
the descriptor from any list before calling vchan_cookie_complete.
next prev parent reply other threads:[~2015-03-02 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 21:19 [PATCH] dmaengine: virt-dma: fix completion list manipulation Robert Jarzmik
2015-03-02 21:29 ` Lars-Peter Clausen [this message]
2015-03-02 22:03 ` Robert Jarzmik
2015-03-03 7:23 ` Lars-Peter Clausen
2015-03-03 10:27 ` Robert Jarzmik
2015-03-03 11:21 ` Lars-Peter Clausen
2015-03-03 11:55 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4D631.6020605@metafoo.de \
--to=lars@metafoo.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox