From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755413AbbCBV30 (ORCPT ); Mon, 2 Mar 2015 16:29:26 -0500 Received: from smtp-out-107.synserver.de ([212.40.185.107]:1200 "EHLO smtp-out-103.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751891AbbCBV3Z (ORCPT ); Mon, 2 Mar 2015 16:29:25 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 10858 Message-ID: <54F4D631.6020605@metafoo.de> Date: Mon, 02 Mar 2015 22:29:21 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Robert Jarzmik , Vinod Koul CC: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: virt-dma: fix completion list manipulation References: <1425331196-7895-1-git-send-email-robert.jarzmik@free.fr> In-Reply-To: <1425331196-7895-1-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2015 10:19 PM, Robert Jarzmik wrote: > diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h > index 3772032..2a3da22 100644 > --- a/drivers/dma/virt-dma.h > +++ b/drivers/dma/virt-dma.h > @@ -91,7 +91,7 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd) > dma_cookie_complete(&vd->tx); > dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n", > vd, cookie); > - list_add_tail(&vd->node, &vc->desc_completed); > + list_move_tail(&vd->node, &vc->desc_completed); That will break all drivers which handle this currently correctly and remove the descriptor from any list before calling vchan_cookie_complete.