From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbbCCCij (ORCPT ); Mon, 2 Mar 2015 21:38:39 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:52819 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbbCCCii (ORCPT ); Mon, 2 Mar 2015 21:38:38 -0500 Message-ID: <54F51E9B.7020807@huawei.com> Date: Tue, 3 Mar 2015 10:38:19 +0800 From: Hou Pengyang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Steven Rostedt CC: , , Subject: Re: [PATCH] ftrace: Fix comments about trace/ftrace.h References: <1425306534-161763-1-git-send-email-houpengyang@huawei.com> <20150302091044.0039be5e@gandalf.local.home> In-Reply-To: <20150302091044.0039be5e@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.95.59] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.54F51EAC.00CF,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b2bc70e7c5cf4d86d91363d904904060 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/2 22:10, Steven Rostedt wrote: > On Mon, 2 Mar 2015 14:28:54 +0000 > Hou Pengyang wrote: > >> commit f42c85e74faa422cf0bc747ed808681145448f88 moves tracepoint's ftrace >> creation into include/trace/ftrace.h and trace/define_trach.h is deleted > > You mean event_trace.h is deleted. yes, commit f42c85e74faa422cf0bc747ed808681145448f88 refactored code, and event_trace.h was deleted. > >> as a result. However some comment info does not adapt to the change, which >> I think is such a misguiding when reading related code. >> >> This patch fix this comment by moving trace/trace_events.h to TRACE_INCLUDE >> (TRACE_INCLUDE_FILE), the macro TRACE_INCLUDE(TRACE_INCLUDE_FILE) is defined >> in trace/define_trace.h >> >> Signed-off-by: Hou Pengyang >> --- >> include/trace/ftrace.h | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h >> index 41bf65f..cb78a8b 100644 >> --- a/include/trace/ftrace.h >> +++ b/include/trace/ftrace.h >> @@ -1,7 +1,8 @@ >> /* >> * Stage 1 of the trace events. >> * >> - * Override the macros in to include the following: >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to > > I agree that the comment needs updating, but not to this. > TRACE_INCLUDE(TRACE_INCLUDE_FILE) is not very descriptive. Because > nobody understand exactly what that is. Do you? > > Change it to: > > Override the macros in the event tracepoint header ... > > And do that for the ones below too. This is more descriptive than just > describing what the code is literally doing. > > -- Steve > To be more descriptive, how about "Override the macros in the event tracepoint header ..." ? since, tracepoint headers have already been moved to trace/events/ . > >> + * include the following: >> * >> * struct ftrace_raw_ { >> * struct trace_entry ent; >> @@ -170,7 +171,8 @@ >> /* >> * Stage 3 of the trace events. >> * >> - * Override the macros in to include the following: >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to >> + * include the following: >> * >> * enum print_line_t >> * ftrace_raw_output_(struct trace_iterator *iter, int flags) >> @@ -479,7 +481,8 @@ static inline notrace int ftrace_get_offsets_##call( \ >> /* >> * Stage 4 of the trace events. >> * >> - * Override the macros in to include the following: >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to >> + * include the following: >> * >> * For those macros defined with TRACE_EVENT: >> * > > > . >