From: Jason Wessel <jason.wessel@windriver.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: <linux-kernel@vger.kernel.org>,
<kgdb-bugreport@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, <patches@linaro.org>,
<linaro-kernel@lists.linaro.org>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value
Date: Mon, 2 Mar 2015 21:25:43 -0600 [thread overview]
Message-ID: <54F529B7.50306@windriver.com> (raw)
In-Reply-To: <1425305616-19656-1-git-send-email-daniel.thompson@linaro.org>
On 03/02/2015 08:13 AM, Daniel Thompson wrote:
> kallsyms_symbol_next() returns a boolean (true on success). Currently
> kdb_read() tests the return value with an inequality that
> unconditionally evaluates to true.
>
> This is fixed in the obvious way and, since the conditional branch is
> supposed to be unreachable, we also add a WARN_ON().
>
Thanks. Applied to kgdb-next. I'll send it along to the upstream
before the end of the v4.0 cycle, we'll see if we pickup any other
fixes along the way. :-)
Cheers,
Jason.
prev parent reply other threads:[~2015-03-03 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:13 [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value Daniel Thompson
2015-03-03 3:25 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F529B7.50306@windriver.com \
--to=jason.wessel@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.thompson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox