public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan@huawei.com>
To: Bandan Das <bsd@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, <cgroups@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: Use kvfree in pidlist_free()
Date: Tue, 3 Mar 2015 11:36:04 +0800	[thread overview]
Message-ID: <54F52C24.9050309@huawei.com> (raw)
In-Reply-To: <jpgioej3tep.fsf@redhat.com>

On 2015/3/3 6:51, Bandan Das wrote:
> 
> The wrapper already calls the appropriate free
> function, use it instead of spinning our own.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>

Acked-by: Zefan Li <lizefan@huawei.com>

> ---
>  kernel/cgroup.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 29a7b2c..c19d66d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3806,10 +3806,7 @@ static void *pidlist_allocate(int count)
>  
>  static void pidlist_free(void *p)
>  {
> -	if (is_vmalloc_addr(p))
> -		vfree(p);
> -	else
> -		kfree(p);
> +	kvfree(p);
>  }
>  
>  /*
> 


  reply	other threads:[~2015-03-03  3:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 22:51 [PATCH] cgroup: Use kvfree in pidlist_free() Bandan Das
2015-03-03  3:36 ` Zefan Li [this message]
2015-03-03 13:47 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F52C24.9050309@huawei.com \
    --to=lizefan@huawei.com \
    --cc=bsd@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox