From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755191AbbCCDgS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 22:36:18 -0500
Received: from szxga01-in.huawei.com ([119.145.14.64]:6148 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753983AbbCCDgR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 22:36:17 -0500
Message-ID: <54F52C24.9050309@huawei.com>
Date: Tue, 3 Mar 2015 11:36:04 +0800
From: Zefan Li <lizefan@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Bandan Das <bsd@redhat.com>
CC: Tejun Heo <tj@kernel.org>, <cgroups@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: Use kvfree in pidlist_free()
References: <jpgioej3tep.fsf@redhat.com>
In-Reply-To: <jpgioej3tep.fsf@redhat.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.18.230]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/3/3 6:51, Bandan Das wrote:
> 
> The wrapper already calls the appropriate free
> function, use it instead of spinning our own.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>

Acked-by: Zefan Li <lizefan@huawei.com>

> ---
>  kernel/cgroup.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 29a7b2c..c19d66d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3806,10 +3806,7 @@ static void *pidlist_allocate(int count)
>  
>  static void pidlist_free(void *p)
>  {
> -	if (is_vmalloc_addr(p))
> -		vfree(p);
> -	else
> -		kfree(p);
> +	kvfree(p);
>  }
>  
>  /*
>