From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbCCDiA (ORCPT ); Mon, 2 Mar 2015 22:38:00 -0500 Received: from mga03.intel.com ([134.134.136.65]:42023 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbbCCDh7 (ORCPT ); Mon, 2 Mar 2015 22:37:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,679,1418112000"; d="scan'208";a="693063059" Message-ID: <54F52C8E.2050705@linux.intel.com> Date: Tue, 03 Mar 2015 11:37:50 +0800 From: "Li, Aubrey" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andy Shevchenko , x86@kernel.org, linux-acpi@vger.kernel.org CC: "Rafael J . Wysocki" , "Kumar P, Mahesh" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] x86: pmc_atom: Add Cherrytrail support References: <1421790603-30097-1-git-send-email-andriy.shevchenko@linux.intel.com> <1424695552.14897.7.camel@linux.intel.com> In-Reply-To: <1424695552.14897.7.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/2/23 20:45, Andy Shevchenko wrote: > On Tue, 2015-01-20 at 23:49 +0200, Andy Shevchenko wrote: >> This is the reworked patch series which had been sent earlier [1] to support >> Intel CherryTrail SoC. >> >> The patches were tested on both BayTrail and CherryTrail SoCs. >> >> [1] https://patchwork.kernel.org/patch/5235891/ > > Aubrey, is everything is clear for you now? Can I send v3 with your > Ack's? > The patches overall look good to me, except a few minor comments need to be addressed in the last conversation. For example, I think we don't need patch 1/4 if we won't use dev_print. some other changes might be necessary only if they makes code cleaner and works better. Certainly, it would be better if other x86 maintainers can take a look at these patches. Thanks, -Aubrey >> >> Changes to v1: >> - rebased on top of recent pmc_atom changes >> - cleaned up, reqorked and split to few smaller patches >> >> Andy Shevchenko (4): >> x86: pmc_atom: save struct device pointer in pmc >> x86: pmc_atom: print index of device in loop >> x86: pmc_atom: supply register mappings via pmc object >> PMC driver: Add Cherrytrail PMC interface >> >> arch/x86/include/asm/pmc_atom.h | 25 ++++ >> arch/x86/kernel/pmc_atom.c | 270 +++++++++++++++++++++++++--------------- >> 2 files changed, 198 insertions(+), 97 deletions(-) >> > >