From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753133AbbCCHsI (ORCPT ); Tue, 3 Mar 2015 02:48:08 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33588 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbCCHsG (ORCPT ); Tue, 3 Mar 2015 02:48:06 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-b7f126d000001e9a-60-54f566a1afd4 Content-transfer-encoding: 8BIT Message-id: <54F56731.3050900@samsung.com> Date: Tue, 03 Mar 2015 08:48:01 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: Bryan Wu Cc: Sakari Ailus , Ingi Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "rpurdie@rpsys.net" , Thierry Reding , p.zabel@pengutronix.de, Andrew Lunn , Greg Kroah-Hartman , florian.vaussard@epfl.ch, arno@natisbad.org, kuninori.morimoto.gx@renesas.com, hytszk@gmail.com, antonynpavlov@gmail.com, "devicetree@vger.kernel.org" , lkml , Linux LED Subsystem , "sw0312.kim@samsung.com" , ideal.song@samsung.com Subject: Re: [PATCH 0/3] Add ktd2692 Flash LED driver References: <1424998891-25591-1-git-send-email-ingi2.kim@samsung.com> <54F02DF5.1000706@samsung.com> <54F40DDF.8070708@samsung.com> <20150302091530.GQ6539@valkosipuli.retiisi.org.uk> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA01RbUhTUQDlvvf29raa3EztIpQ0MMHwY5B1K5GwHz1CSfvCMrCpSy2ntqmk QWkqpOWcaCymZmtpbk3FWeSmtpq6IpeaEiXpBllRa0WhhlJazv3If4dzDuccOAzpa6UCmayc fIksR5wtpPnU8PKz12GaM/NHIy2LAXh02kria8vfOHj0iZ3AQ6ZaAjcPjnCw3aUAuMat4eAy bSeNjeXtAJuXnACPuHQA90zO0dg1YAZ4wtxI44fuDoBb3rwi8LTjOYWVqnYKV/QPcnGv+eNK lEVH45t1X2j87rfPvk2s4ZYBsBOKaoJtrbhPsib1NJfV3Zuj2YF5DcUa9ZU0a2kycFlTzyzB Nj2a4bLVZd9ptmYpkv1lr6XYvuYFDqt4oAfsrHFLAjzJj06XZGcVSmQRMaf5mQtjTipP6X/B bG7glIAOWAV4DII7UJv2B9eLA9CYo5OuAnzGF7YAVO+2cjyCAG5AC3UOqgowDAmD0OD4OQ9N wp3ofXkH6fX/BKjZ6SC8/lDUW9kFPJiCweil69NqAQ1FaPHz11WPP0xCf4Yfr+b7wa1I47YQ 3tAWGpU3JXvwRhiFpoaqKG9BKYH63P2UR+DBI+hqSxtHCaB6zT71/33qNftuA1IP/CUFaXny 1AypKFwulsoLcjLC03KlRuD9fa4HaG17rAAyQLhe0BM6f9SXIy6UF0mtADGk0E8Qk7JCCdLF RcUSWW6KrCBbIrcCguEFlgD9+ReNioPLl1THMlXWaGeD1kgEmVSxH1yllraIp39tlVFMyJXW cHhWF7k3lhcyerz5btHh4vqZIr1rypCgtNvWdXcna+Ps226cilduThq/E99w/TKRrzdPJ24/ EKGqiUYXJxN5+1MPdQWHxfMDo32oE29jbXFZIf2hu3eJxpGQkmeKRaGkTC7+BypxP2rVAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2015 09:07 PM, Bryan Wu wrote: > On Mon, Mar 2, 2015 at 1:15 AM, Sakari Ailus wrote: >> H Ingi, >> >> On Mon, Mar 02, 2015 at 04:14:39PM +0900, Ingi Kim wrote: >>> Hi Jacek >>> >>> On 2015년 02월 27일 17:42, Jacek Anaszewski wrote: >>>> Hi Ingi, >>>> >>>> On 02/27/2015 02:01 AM, Ingi Kim wrote: >>>>> This patch supports KTD2692 flash LED driver >>>>> >>>>> Ingi Kim (3): >>>>> of: Add vendor prefix for Kinetic technologies >>>>> leds: ktd2692: add device tree bindings for ktd2692 >>>>> leds: Add ktd2692 flash LED driver >>>>> >>>>> .../devicetree/bindings/leds/leds-ktd2692.txt | 19 ++ >>>>> .../devicetree/bindings/vendor-prefixes.txt | 1 + >>>>> drivers/leds/Kconfig | 8 + >>>>> drivers/leds/Makefile | 1 + >>>>> drivers/leds/leds-ktd2692.c | 245 ++++++++++++++++++++ >>>>> 5 files changed, 274 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt >>>>> create mode 100644 drivers/leds/leds-ktd2692.c >>>>> >>>> >>>> In your device tree binding documentation there is torch-gpio mentioned, >>>> but you seem not to use it in the driver. >>>> >>>> We have already LED Flash class (/drivers/leds/led-class-flash.c) for >>>> this type of devices, which handles both torch and flash modes >>>> (flash_strobe sysfs attribute is provided for strobing the flash). >>>> >>>> The reference drivers using LED Flash class are still pending [1], but I >>>> think that at least leds-aat1290 driver is almost ready for merging. >>>> It controls very similar device to yours. >>>> >>>> Another advantage of using LED Flash class is that it has been designed >>>> to be compatible with Video for Linux 2 subsystem, which will allow for registering LED Flash class devices as a V4L2 sub-devices. >>>> >>>> Adding Sakari. >>>> >>> >>> Ok, I'll check LED Flash class, and add torch-gpio >> >> Many LED flash chips include a hardware pin for torch control but few really >> need it. If you don't, i.e. you can implement the torch using the control bus >> instead, I think I'd probably drop it from the chip's DT bindings. >> > > Ingi, please follow Jacek's advice to use LED Flash class interface. > I'm reviewing those leds flash drivers and probably merge them soon. Bryan please hold on with merging them as I am about to send new patch set, as we've agreed that synchronized strobe feature should be removed from the LED Flash class. There will be also some tweaking around aat1290 DT bindings. -- Best Regards, Jacek Anaszewski