From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709AbbCCH7F (ORCPT ); Tue, 3 Mar 2015 02:59:05 -0500 Received: from www.linutronix.de ([62.245.132.108]:36624 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754491AbbCCH7D (ORCPT ); Tue, 3 Mar 2015 02:59:03 -0500 Message-ID: <54F569C4.3070409@linutronix.de> Date: Tue, 03 Mar 2015 08:59:00 +0100 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: cfredric , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixing style warnings. References: <20150303051954.GA23116@khanti> In-Reply-To: <20150303051954.GA23116@khanti> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2015 06:19 AM, cfredric wrote: > Signed-off-by: cfredric You could use your full name here. > --- > drivers/usb/core/buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c > index 506b969..89f2e77 100644 > --- a/drivers/usb/core/buffer.c > +++ b/drivers/usb/core/buffer.c > @@ -70,7 +70,7 @@ int hcd_buffer_create(struct usb_hcd *hcd) > size = pool_max[i]; > if (!size) > continue; > - snprintf(name, sizeof name, "buffer-%d", size); > + snprintf(name, sizeof(name), "buffer-%d", size); This looks like checkpactch warning you fixed. You could add something to the patch description that says so. > hcd->pool[i] = dma_pool_create(name, hcd->self.controller, > size, size, 0); > if (!hcd->pool[i]) { > @@ -95,6 +95,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd) > > for (i = 0; i < HCD_BUFFER_POOLS; i++) { > struct dma_pool *pool = hcd->pool[i]; > + This looks unrelated. > if (pool) { > dma_pool_destroy(pool); > hcd->pool[i] = NULL; > Sebastian