Re: [PATCH v3 00/15] media: blackfin: bfin_capture enhancements

Hans Verkuil
2015-03-03T09:39:32Z

On 03/03/2015 10:30 AM, Lad, Prabhakar wrote:
> Hi Hans,
>
> On Tue, Mar 3, 2015 at 8:49 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On 03/02/2015 08:57 AM, Scott Jiang wrote:
>>> Hi Lad and Hans,
>>>
>>> 2015-02-22 2:39 GMT+08:00 Lad Prabhakar <prabhakar.csengg@gmail.com>:
>>>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>>>
>>>> This patch series, enhances blackfin capture driver with
>>>> vb2 helpers.
>>>>
>>>> Changes for v3:
>>>> 1: patches unchanged except for patch 8/15 fixing starting of ppi only
>>>> after we have the resources.
>>>> 2: Rebased on media tree.
>>>>
>>>> v2: http://lkml.iu.edu/hypermail/linux/kernel/1501.2/04655.html
>>>>
>>>> v1: https://lkml.org/lkml/2014/12/20/27
>>>>
>>>> Lad, Prabhakar (15):
>>>> media: blackfin: bfin_capture: drop buf_init() callback
>>>> media: blackfin: bfin_capture: release buffers in case
>>>> start_streaming() call back fails
>>>> media: blackfin: bfin_capture: set min_buffers_needed
>>>> media: blackfin: bfin_capture: improve buf_prepare() callback
>>>> media: blackfin: bfin_capture: improve queue_setup() callback
>>>> media: blackfin: bfin_capture: use vb2_fop_mmap/poll
>>>> media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release
>>>> media: blackfin: bfin_capture: use vb2_ioctl_* helpers
>>>> media: blackfin: bfin_capture: make sure all buffers are returned on
>>>> stop_streaming() callback
>>>> media: blackfin: bfin_capture: return -ENODATA for *std calls
>>>> media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls
>>>> media: blackfin: bfin_capture: add support for vidioc_create_bufs
>>>> media: blackfin: bfin_capture: add support for VB2_DMABUF
>>>> media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF
>>>> media: blackfin: bfin_capture: set v4l2 buffer sequence
>>>>
>>>> drivers/media/platform/blackfin/bfin_capture.c | 306 ++++++++-----------------
>>>> 1 file changed, 94 insertions(+), 212 deletions(-)
>>>>
>>>> --
>>>
>>> For all these patches,
>>> Acked-by: Scott Jiang <scott.jiang.linux@gmail.com>
>>> Tested-by: Scott Jiang <scott.jiang.linux@gmail.com>
>>
>> Thanks!
>>
>> Is it possible for you to run 'v4l2-compliance -s' with this driver and
>> report the results? I'd be interested in that.
>>
> Fyi..
> v4l2-utils can't be compiled under uClibc.

Do you know what exactly fails? Is it possible to manually compile v4l2-compliance?

I.e., try this:

cd utils/v4l2-compliance
cat *.cpp >x.cpp
g++ -o v4l2-compliance x.cpp -I . -I ../../include/ -DNO_LIBV4L2

I've never used uclibc, so I don't know what the limitations are.

Regards,

Hans