From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755857AbbCCKJS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 05:09:18 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:54368 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752441AbbCCKJP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 05:09:15 -0500
X-IronPort-AV: E=Sophos;i="5.09,681,1418083200"; 
   d="scan'208";a="240867733"
Message-ID: <54F58845.1040001@citrix.com>
Date: Tue, 3 Mar 2015 10:09:09 +0000
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Tao Chen <boby.chen@huawei.com>, <jgross@suse.com>,
        <konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
        <david.vrabel@citrix.com>
CC: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <xen-devel@lists.xenproject.org>, <rudy.zhangmin@huawei.com>,
        <wu.wubin@huawei.com>
Subject: Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros
References: <1425371832-55072-1-git-send-email-boby.chen@huawei.com>
In-Reply-To: <1425371832-55072-1-git-send-email-boby.chen@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/03/15 08:37, Tao Chen wrote:
> Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX,
> it makes the code easier to read.

You need to #define pr_fmt(fmt) to add a prefix like this.

>  	struct ids_tuple v;		/* translate from */
> -	struct scsiback_tpg *tpg;	/* translate to   */
> +	struct scsiback_tpg *tpg;	/* translate to */

Please don't make unrelated whitespace changes.

David