From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756196AbbCCKOu (ORCPT ); Tue, 3 Mar 2015 05:14:50 -0500 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:40465 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085AbbCCKOs (ORCPT ); Tue, 3 Mar 2015 05:14:48 -0500 Message-ID: <54F58988.1040404@xs4all.nl> Date: Tue, 03 Mar 2015 11:14:32 +0100 From: Hans Verkuil User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Lad Prabhakar , Scott Jiang , adi-buildroot-devel@lists.sourceforge.net CC: Mauro Carvalho Chehab , LMML , LKML Subject: Re: [PATCH v3 06/15] media: blackfin: bfin_capture: use vb2_fop_mmap/poll References: <1424544001-19045-1-git-send-email-prabhakar.csengg@gmail.com> <1424544001-19045-7-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1424544001-19045-7-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2015 07:39 PM, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > No need to reinvent the wheel. Just use the already existing > functions provided by vb2. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/blackfin/bfin_capture.c | 28 +++----------------------- > 1 file changed, 3 insertions(+), 25 deletions(-) > > diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c > index be0d0a2b..ee0e848 100644 > --- a/drivers/media/platform/blackfin/bfin_capture.c > +++ b/drivers/media/platform/blackfin/bfin_capture.c > @@ -244,18 +244,6 @@ static int bcap_release(struct file *file) > return 0; > } > > -static int bcap_mmap(struct file *file, struct vm_area_struct *vma) > -{ > - struct bcap_device *bcap_dev = video_drvdata(file); > - int ret; > - > - if (mutex_lock_interruptible(&bcap_dev->mutex)) > - return -ERESTARTSYS; > - ret = vb2_mmap(&bcap_dev->buffer_queue, vma); > - mutex_unlock(&bcap_dev->mutex); > - return ret; > -} > - > #ifndef CONFIG_MMU > static unsigned long bcap_get_unmapped_area(struct file *file, > unsigned long addr, > @@ -273,17 +261,6 @@ static unsigned long bcap_get_unmapped_area(struct file *file, This can also be replaced by vb2_fop_get_unmapped_area(). Patch is welcome :-) Regards, Hans