From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755866AbbCCKRL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 05:17:11 -0500
Received: from mx08-00178001.pphosted.com ([91.207.212.93]:42254 "EHLO
	mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751535AbbCCKRI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 05:17:08 -0500
Message-ID: <54F58A01.7090806@st.com>
Date: Tue, 3 Mar 2015 11:16:33 +0100
From: Maxime Coquelin <maxime.coquelin@st.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Peter Griffin <peter.griffin@linaro.org>, Lee Jones <lee.jones@linaro.org>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <srinivas.kandagatla@gmail.com>, <patrice.chotard@st.com>,
        <kishon@ti.com>, <balbi@ti.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
References: <1424871377-1795-1-git-send-email-peter.griffin@linaro.org> <1424871377-1795-5-git-send-email-peter.griffin@linaro.org> <20150225151229.GE5132@x1> <20150225152201.GA14329@griffinp-ThinkPad-X1-Carbon-2nd> <20150225155005.GE6688@x1> <20150227104353.GB9094@griffinp-ThinkPad-X1-Carbon-2nd>
In-Reply-To: <20150227104353.GB9094@griffinp-ThinkPad-X1-Carbon-2nd>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.201.23.80]
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000
 definitions=2015-03-03_03:2015-03-03,2015-03-03,1970-01-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 02/27/2015 11:43 AM, Peter Griffin wrote:
> Hi Lee,
>
> On Wed, 25 Feb 2015, Lee Jones wrote:
>
>>>>> +			reset-names	= "powerdown",
>>>>> +					  "softreset";
>>>> Nit: What's the purpose of having these on separate lines?
>>> The only reason was to stay aligned with the example in
>>> Documentation/devicetree/bindings/usb/dwc3-st.txt.
>> But didn't you author that too? :)
> Yep
>
>> I would change them both.  No need to force a line wrap if it's not required.
> Ok, I'll remove it from both in v2, whilst adding the acks.
Thanks. Once fixed, you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

BR,
Maxime
>
> regards,
>
> Peter.