From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756538AbbCCMXr (ORCPT ); Tue, 3 Mar 2015 07:23:47 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:53568 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755022AbbCCMXp (ORCPT ); Tue, 3 Mar 2015 07:23:45 -0500 Message-ID: <54F5A7AD.9000906@st.com> Date: Tue, 3 Mar 2015 13:23:09 +0100 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Griffin , , , , , CC: , , Subject: Re: [PATCH 0/3] Enable ahci_st for stih407 and fix hang References: <1425300519-13747-1-git-send-email-peter.griffin@linaro.org> In-Reply-To: <1425300519-13747-1-git-send-email-peter.griffin@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-03-03_04:2015-03-03,2015-03-03,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 03/02/2015 01:48 PM, Peter Griffin wrote: > Hi, > > Now that miphy28lp phy is present upstream we can add sata DT nodes for > stih407 family silicon. As part of testing this I found a hang > with the current driver implmentation which does some register writes > before enabling the IP clock. Presumably on stih416 devices the sata > clock must have already been enabled by the targetpack/bootloader. > > This series also tidys up some inaccuracies in the DT documentation > where the doc hasn't kept aligned with the driver. In addtion to these > fixes I've also added an example for stih407 silicon. > > Peter Griffin (3): > ahci: st: Update the ahci_st DT documentation > ARM: DT: STi: STiH407: Add sata DT nodes. > ahci: st: st_configure_oob must be called after IP is clocked. > > Documentation/devicetree/bindings/ata/ahci-st.txt | 45 ++++++++++++++++------- > arch/arm/boot/dts/stih407-family.dtsi | 44 ++++++++++++++++++++++ > drivers/ata/ahci_st.c | 6 ++- > 3 files changed, 80 insertions(+), 15 deletions(-) > For the series, you can add my: Acked-by: Maxime Coquelin Thanks, Maxime