From: Roger Quadros <rogerq@ti.com>
To: Axel Lin <axel.lin@ingics.com>, Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vignesh R <vigneshr@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: ti-pipe3: Simplify ti_pipe3_dpll_wait_lock implementation
Date: Tue, 3 Mar 2015 14:57:56 +0200 [thread overview]
Message-ID: <54F5AFD4.2080800@ti.com> (raw)
In-Reply-To: <1425384295.23394.0.camel@phoenix>
On 03/03/15 14:04, Axel Lin wrote:
> Code simplification. No functional change.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/phy/phy-ti-pipe3.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
> index 95c88f9..ed72b0d 100644
> --- a/drivers/phy/phy-ti-pipe3.c
> +++ b/drivers/phy/phy-ti-pipe3.c
> @@ -165,15 +165,11 @@ static int ti_pipe3_dpll_wait_lock(struct ti_pipe3 *phy)
> cpu_relax();
> val = ti_pipe3_readl(phy->pll_ctrl_base, PLL_STATUS);
> if (val & PLL_LOCK)
> - break;
> + return 0;
> } while (!time_after(jiffies, timeout));
>
> - if (!(val & PLL_LOCK)) {
> - dev_err(phy->dev, "DPLL failed to lock\n");
> - return -EBUSY;
> - }
> -
> - return 0;
> + dev_err(phy->dev, "DPLL failed to lock\n");
> + return -EBUSY;
> }
>
> static int ti_pipe3_dpll_program(struct ti_pipe3 *phy)
>
prev parent reply other threads:[~2015-03-03 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:04 [PATCH] phy: ti-pipe3: Simplify ti_pipe3_dpll_wait_lock implementation Axel Lin
2015-03-03 12:57 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5AFD4.2080800@ti.com \
--to=rogerq@ti.com \
--cc=axel.lin@ingics.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox