From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756499AbbCCOWs (ORCPT ); Tue, 3 Mar 2015 09:22:48 -0500 Received: from mail-la0-f52.google.com ([209.85.215.52]:35102 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755628AbbCCOWo (ORCPT ); Tue, 3 Mar 2015 09:22:44 -0500 Message-ID: <54F5C3B0.7080209@cogentembedded.com> Date: Tue, 03 Mar 2015 17:22:40 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: Nicholas Mc Guire , "David S. Miller" , Joe Perches , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ide_tape: convert jiffies with jiffies_to_msecs References: <1425379971-12641-1-git-send-email-hofrat@osadl.org> <54F5C101.9070409@cogentembedded.com> <20150303141509.GA30541@opentech.at> In-Reply-To: <20150303141509.GA30541@opentech.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/3/2015 5:15 PM, Nicholas Mc Guire wrote: >>> Use jiffies_to_msecs for converting jiffies as it handles all of the corner >>> cases reliably and also helps readability. The printk format is fixed up >>> as jiffies_to_msecs returns unsigned int not unsigned long. >>> Signed-off-by: Nicholas Mc Guire >>> --- >>> v2: change printk format string from %d to %u as suggested by >>> Joe Perches . >>> Note that this patch will give a checkpatch warning due to "quoted string >>> split across lines" but thats not related to this change. >>> This was only compile tested with x86_64_defconfig + CONFIG_IDE=m, >>> CONFIG_BLK_DEV_IDETAPE=m >>> Patch is against 4.0-rc1 (localversion-next is -next-20150303) >>> drivers/ide/ide-tape.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> The driver is called ide-tape.c, yet your subject prefix is "ide_tape:". > that is based on the output of git log --oneline and it seems that it is > the common prefix - in fact it seem rare to use the c-file name as prefix > for patch subjects. Huh, what else is to be used for the prefix if not the file name? I would really like the prefix to be changed to "ide-tape", however it's up for DaveM, of course. > thx! > ofrat WBR, Sergei