From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932137AbbCCO3F (ORCPT ); Tue, 3 Mar 2015 09:29:05 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:23049 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756752AbbCCO3C (ORCPT ); Tue, 3 Mar 2015 09:29:02 -0500 Message-ID: <54F5C4D6.9010907@oracle.com> Date: Tue, 03 Mar 2015 09:27:34 -0500 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Luis R. Rodriguez" , David Vrabel CC: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, "linux-kernel@vger.kernel.org" , Andy Lutomirski Subject: Re: [Xen-devel] [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests References: <1424707260-4302-1-git-send-email-boris.ostrovsky@oracle.com> <54EB5EC7.2020300@citrix.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2015 12:35 AM, Luis R. Rodriguez wrote: > On Mon, Feb 23, 2015 at 9:09 AM, David Vrabel wrote: >> On 23/02/15 16:01, Boris Ostrovsky wrote: >>> Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") >>> introduced CR4 shadows. >>> >>> These shadows are initialized in early boot code. The commit missed >>> initialization for 64-bit PV(H) guests that this patch adds. >> Applied to stable/for-linus-4.0, thanks. >> >> Boris, can you kick of a set of tests on this branch, please? > Do we know worst case what should blow up without this commit ? PVH guest will crash. -boris