From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757053AbbCCPfB (ORCPT ); Tue, 3 Mar 2015 10:35:01 -0500 Received: from service87.mimecast.com ([91.220.42.44]:46316 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757039AbbCCPe7 convert rfc822-to-8bit (ORCPT ); Tue, 3 Mar 2015 10:34:59 -0500 Message-ID: <54F5D49F.2060408@arm.com> Date: Tue, 03 Mar 2015 15:34:55 +0000 From: Kapileshwar Singh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Viresh Kumar CC: Javi Merino , Eduardo Valentin , Zhang Rui , Linux PM list , "linux-kernel@vger.kernel.org" , Punit Agrawal , Lina Iyer , Mark Brown , Jon Medhurst Subject: Re: [PATCH v3 5/5] thermal: cpu_cooling: update the cpu device when cpufreq updates the policy cpu References: <1425316643-31991-1-git-send-email-javi.merino@arm.com> <1425316643-31991-6-git-send-email-javi.merino@arm.com> <54F5941F.6030402@arm.com> <54F59DEF.3020700@arm.com> <54F5CEBC.1070303@arm.com> In-Reply-To: X-OriginalArrivalTime: 03 Mar 2015 15:34:56.0294 (UTC) FILETIME=[99EB6C60:01D055C7] X-MC-Unique: 115030315345614101 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/15 15:29, Viresh Kumar wrote: > On 3 March 2015 at 20:39, Kapileshwar Singh wrote: > >> I did test this but we were working with the assumption that OPPs should be populated for all the CPUs and also that OPPs are lost for a hotplugged CPU which I see is not the case. > > Then what did you test? My point here is, even with the latest patches > that you have > sent, you wouldn't be able to get the OPPs once policy->cpu goes down. So, how > did this worked for you ? We were basing our fix on possibility of having OPPs for all the CPUs and we incorrectly attributed the erroneous OPP we got from dev_pm_opp_find_freq_exact to the missing OPPs in the other CPUs. > >> We have looked at this more closely and found that problem lies in: >> >> freq = cpufreq_quick_get(cpumask_any(&cpufreq_device->allowed_cpus)); >> >> which returns a NULL frequency as we are not checking for online CPUs here. We shall come up with a fix for this. Many thanks for helping us with the investigation. > > Right. >