From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757109AbbCCPfr (ORCPT ); Tue, 3 Mar 2015 10:35:47 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:12650 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046AbbCCPfp (ORCPT ); Tue, 3 Mar 2015 10:35:45 -0500 Message-ID: <54F5D4CC.3090805@atmel.com> Date: Tue, 3 Mar 2015 16:35:40 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Boris Brezillon , Thomas Gleixner , Jason Cooper , Peter Zijlstra , Mark Rutland , "Rafael J. Wysocki" CC: Len Brown , Pavel Machek , , Wim Van Sebroeck , , Alessandro Zummo , , Greg Kroah-Hartman , Jiri Slaby , , Mike Turquette , , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Subject: Re: [PATCH v2 0/6] ARM: at91: fix irq_pm_install_action WARNING References: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 02/03/2015 10:18, Boris Brezillon a écrit : > My apologies to those of you who already received this series, but I > didn't increment the patch version and forgot some subsystem maintainers > and MLs. > > Commit cab303be91dc47942bc25de33dc1140123540800 [1] introduced a WARN_ON > test which triggers a WARNING backtrace on at91 platforms. > While this WARN_ON is absolutely necessary to warn users that they should > not mix request with and without IRQF_NO_SUSPEND flags on shared IRQs, > there is no easy way to solve this issue on at91 platforms. > > The main reason is that the init timer is often using a shared irq line > and thus request this irq with IRQF_NO_SUSPEND flag set, while other > peripherals request the same irq line without this flag. > > This problem has recently been addressed by this patch [2] which adds > a new IRQF_COND_SUSPEND flag, that authorize mixing IRQF_NO_SUSPEND and > !IRQF_NO_SUSPEND as long as irq handlers setting IRQF_COND_SUSPEND > can safely be called in suspended state. > > Doing this also implies taking care of system wakeup in devices handlers > if they tag the IRQ line as a wakeup source. > The first patch of this series exports the pm_system_wakeup symbol so > that drivers can call pm_system_wakeup from their interrupt handler. > > This series then patches all at91 drivers that can have devices sharing > their IRQ line with a timer. > > This series depends on [2]. I'm okay with all the patches: Acked-by: Nicolas Ferre As it seems easier to keep the whole series together, I'll let Rafael take it. Thanks a lot for having taking care of this. Best regards, > [1]https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/kernel/irq/pm.c?id=cab303be91dc47942bc25de33dc1140123540800 > [2]https://lkml.org/lkml/2015/2/26/675 > > Changes since v1: > - replaced the IRQF_SUSPEND_NOACTION flag by IRQF_COND_SUSPEND > - properly addressed wakeup handling in drivers > > Boris Brezillon (6): > PM / wakeup: export pm_system_wakeup symbol > rtc: at91sam9: rework wakeup and interrupt handling > rtc: at91rm9200: rework wakeup and interrupt handling > clk: at91: implement suspend/resume for the PMC irqchip > watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND > tty: serial: atmel: rework interrupt and wakeup handling > > drivers/base/power/wakeup.c | 1 + > drivers/clk/at91/pmc.c | 20 ++++++++++- > drivers/clk/at91/pmc.h | 1 + > drivers/rtc/rtc-at91rm9200.c | 62 +++++++++++++++++++++++++-------- > drivers/rtc/rtc-at91sam9.c | 73 ++++++++++++++++++++++++++++++++------- > drivers/tty/serial/atmel_serial.c | 49 +++++++++++++++++++++++--- > drivers/watchdog/at91sam9_wdt.c | 3 +- > 7 files changed, 177 insertions(+), 32 deletions(-) > -- Nicolas Ferre