From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331AbbCCQsz (ORCPT ); Tue, 3 Mar 2015 11:48:55 -0500 Received: from nopam.alitech.com ([202.3.176.31]:52515 "EHLO nopam.alitech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757195AbbCCQsw convert rfc822-to-8bit (ORCPT ); Tue, 3 Mar 2015 11:48:52 -0500 X-Greylist: delayed 1244 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 Mar 2015 11:48:52 EST split_mail: 1 Message-ID: <54F5E120.3090705@alitech.com> Date: Tue, 03 Mar 2015 17:28:16 +0100 From: Christian Ruppert User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexey Brodkin , linux-i2c@vger.kernel.org CC: linux-kernel@vger.kernel.org, Vineet Gupta , Christian Ruppert , Mika Westerberg , Wolfram Sang Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER References: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> In-Reply-To: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> X-MIMETrack: =?Big5?B?SXRlbWl6ZSBieSBTTVRQIFNlcnZlciBvbiBUV0FMSU5TMi9BTElfVFBFL0FMaSg=?= =?Big5?B?UmVsZWFzZSA4LjAuMkZQNnxKdWx5IDE1LCAyMDEwKSBhdCAyMDE1LzAzLzA0IKRX?= =?Big5?B?pMggMTI6Mjk6MTA=?=, =?Big5?B?U2VyaWFsaXplIGJ5IFJvdXRlciBvbiBUV0FMSU5TMi9BTElfVFBFL0FMaSg=?= =?Big5?B?UmVsZWFzZSA4LjAuMkZQNnxKdWx5IDE1LCAyMDEwKSBhdCAyMDE1LzAzLzA0IKRX?= =?Big5?B?pMggMTI6Mjk6MTE=?= X-TNEFEvaluated: 1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-03-03 16:27, Alexey Brodkin wrote: > There's no point in printing error message if platform_get_irq() > returns -EPROBE_DEFER because probe deferring subsystem already outputs > message in bootlog like this: > --->8--- > platform e001d000.i2c: Driver i2c_designware requests probe deferral > --->8--- > > Moreover in case of probe deferral following message may mislead user: > --->8--- > i2c_designware e001d000.i2c: no irq resource? > --->8--- > even though it's expected that platform_get_irq() may return > -EPROBE_DEFER. > > Signed-off-by: Alexey Brodkin > Cc: Vineet Gupta > Cc: Christian Ruppert > Cc: Mika Westerberg > Cc: Wolfram Sang > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index c270f5f..01c1b17 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -144,7 +144,8 @@ static int dw_i2c_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "no irq resource?\n"); > + if (irq != -EPROBE_DEFER) > + dev_err(&pdev->dev, "no irq resource?\n"); Presented like this I wonder if this merits being a dev_err at all. Wouldn't dev_dbg be more adequate? This might remove the need for the condition and also avoid bothering everyone if something in the platform device structures or device tree is not right. > return irq; /* -ENXIO */ > } > >