From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932316AbbCCRto (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 12:49:44 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:51699 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757639AbbCCRtm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 12:49:42 -0500
Message-ID: <54F5F414.2070608@oracle.com>
Date: Tue, 03 Mar 2015 10:49:08 -0700
From: David Ahern <david.ahern@oracle.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org
CC: Arnaldo Carvalho de Melo <acme@redhat.com>,
        Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 12/14] tools build: Allow to override feature checks setup
References: <1425392797-22572-1-git-send-email-jolsa@kernel.org> <1425392797-22572-13-git-send-email-jolsa@kernel.org>
In-Reply-To: <1425392797-22572-13-git-send-email-jolsa@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/3/15 7:26 AM, Jiri Olsa wrote:
> Allowing to override configuration variables for feature
> checks. Also adding automated test and documentation.

Rather than an 'override' why not require users to specify feature 
checks of interest? ie., the previous patch moved all of perf's feature 
checks to a common Makefile. Why not have perf specify features of 
interest to it instead?

David