Re: [PATCH 12/14] tools build: Allow to override feature checks setup

Jiri Olsa
2015-03-03T17:56:29Z

On Tue, Mar 03, 2015 at 10:49:08AM -0700, David Ahern wrote:
> On 3/3/15 7:26 AM, Jiri Olsa wrote:
> >Allowing to override configuration variables for feature
> >checks. Also adding automated test and documentation.
>
> Rather than an 'override' why not require users to specify feature checks of
> interest? ie., the previous patch moved all of perf's feature checks to a
> common Makefile. Why not have perf specify features of interest to it
> instead?

well, thats what they can do as you can see in the example:

+ FEATURE_TESTS := glibc backtrace
+ FEATURE_DISPLAY := glibc
+
+ srctree := ../../../..
+ include $(srctree)/tools/build/Makefile.feature

you specify features you want to check in FEATURE_TESTS variable
and features status you want to display in FEATURE_DISPLAY variable

at the mean time the default settings for those 2 is what
perf uses now (perf is the only user)

in future when there's multiple users, perf will set those
variables as well..

jirka