From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757108AbbCCTFz (ORCPT ); Tue, 3 Mar 2015 14:05:55 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:49811 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbCCTFy (ORCPT ); Tue, 3 Mar 2015 14:05:54 -0500 Message-ID: <54F60614.8070307@atmel.com> Date: Tue, 3 Mar 2015 20:05:56 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexandre Belloni CC: Jean-Christophe Plagniol-Villard , Wenyou Yang , , , Boris Brezillon Subject: Re: [PATCH] ARM: at91: pm: fix at91rm9200 standby References: <1425409102-29337-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1425409102-29337-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/03/2015 19:58, Alexandre Belloni a écrit : > at91rm9200 standby and suspend to ram has been broken since > 00482a4078f4. It is wrongly using AT91_BASE_SYS which is a physical address > and actually doesn't correspond to any register on at91rm9200. > > Use the correct at91_ramc_base[0] instead. > > Fixes: 00482a4078f4 (ARM: at91: implement the standby function for pm/cpuidle) > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre and immediately added to at91-4.0-fixes. Thanks. Bye, > --- > arch/arm/mach-at91/pm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h > index d2c89963af2d..86c0aa819d25 100644 > --- a/arch/arm/mach-at91/pm.h > +++ b/arch/arm/mach-at91/pm.h > @@ -44,7 +44,7 @@ static inline void at91rm9200_standby(void) > " mcr p15, 0, %0, c7, c0, 4\n\t" > " str %5, [%1, %2]" > : > - : "r" (0), "r" (AT91_BASE_SYS), "r" (AT91RM9200_SDRAMC_LPR), > + : "r" (0), "r" (at91_ramc_base[0]), "r" (AT91RM9200_SDRAMC_LPR), > "r" (1), "r" (AT91RM9200_SDRAMC_SRR), > "r" (lpr)); > } > -- Nicolas Ferre