From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757255AbbCCUVI (ORCPT ); Tue, 3 Mar 2015 15:21:08 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:40944 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756618AbbCCUVE (ORCPT ); Tue, 3 Mar 2015 15:21:04 -0500 Message-ID: <54F617AD.6070208@wwwdotorg.org> Date: Tue, 03 Mar 2015 13:21:01 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Linus Walleij CC: linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Warren Subject: Re: [PATCH 1/4] pinctrl: tegra: driver layout/consistency fixes References: <1424811651-18660-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1424811651-18660-1-git-send-email-swarren@wwwdotorg.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2015 02:00 PM, Stephen Warren wrote: > From: Stephen Warren > > Various non-semantic tweaks and layout/consistency fixes for existing > Tegra pinctrl drivers. > > Move the definition of DRV_PINGROUP_REG() before the definition of > PINGROUP() so that a future SoC driver can invoke the former from the > latter. > > PINGROUP_BIT_Y(n) is just n, so replace it with n. > > Re-wrap the parameters to *PINGROUP(). > > Keep various enums sorted in the Tegra124 driver. > > Various white-space consistency fixes. > > These changes aim to update existing drivers to be consistent with future > SoC drivers. While we could ignore these tweaks to the existing drivers, > I'd like to keep everything as consistent as possible for easy comparison. > Besides, I auto-generate the drivers, and maintaining special-cases to > keep the differences in place is annoying. Linus, does this series look OK?