From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758196AbbCDGXD (ORCPT ); Wed, 4 Mar 2015 01:23:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42877 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbbCDGW7 (ORCPT ); Wed, 4 Mar 2015 01:22:59 -0500 Message-ID: <54F6A4BE.1070104@codeaurora.org> Date: Wed, 04 Mar 2015 11:52:54 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Stephane Viau , dri-devel@lists.freedesktop.org CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com Subject: Re: [PATCH 2/4] drm/msm/mdp5: Enhance operation mode for pipeline configuration References: <1425407775-7704-1-git-send-email-sviau@codeaurora.org> <1425407775-7704-3-git-send-email-sviau@codeaurora.org> In-Reply-To: <1425407775-7704-3-git-send-email-sviau@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/04/2015 12:06 AM, Stephane Viau wrote: > DSI and WB interfaces need a more complex pipeline configuration > than the current mdp5_ctl_set_intf(). > > For example, memory output connections need to be selected for > WB. Interface mode (Video vs. Command modes) also need to be > configured for DSI. > > This change takes care of configuring the whole pipeline as far > as operation mode goes. DSI and WB interfaces will be added > later. > > Signed-off-by: Stephane Viau > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 2 + > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 39 ++----------- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 91 +++++++++++++++++++++++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 3 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 29 +++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 16 ++++- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 48 ++++++++++++--- > 7 files changed, 157 insertions(+), 71 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > index dba4d52..be587b8 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > @@ -31,6 +31,8 @@ extern const struct mdp5_cfg_hw *mdp5_cfg; > > typedef DECLARE_BITMAP(mdp5_smp_state_t, MAX_SMP_BLOCKS); > > +#define MDP5_INTF_IS_VIRTUAL_DISPLAY(intf_type) ((intf_type) >= INTF_VIRTUAL) > + Minor comment and probably matter of taste. Having the above as mdp5_intf_is_virtual() would seem better in the code. Thanks, Archit