Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

Mark Brown
2015-03-06T11:44:26Z

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Wed, Mar 04, 2015 at 09:00:39AM +0100, leroy christophe wrote:
> Le 03/03/2015 19:44, Mark Brown a écrit :

> >Why are we using of_iomap() rather than a generic I/O mapping function
> >here?

> because all drivers for powerpc seems to be using of_iomap(), as on powerpc
> the HW is described by the bootloader in a OF device tree.
> Today, of_iomap() is at least used in FSL SPI, FSL UART, SPI mpc52xx, UART
> mpc52xx, i2c-mpc, i2c-cpm, freescale ethernet drivers, etc ....

> Is it not correct ?

It's legacy, all that code is really old. Modern code is written in as
architecture and firmware neutral a fashion as possible to make things
more consistent and maintainable.