From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759545AbbCDJDl (ORCPT ); Wed, 4 Mar 2015 04:03:41 -0500 Received: from mail-bn1on0140.outbound.protection.outlook.com ([157.56.110.140]:20058 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758042AbbCDJDi (ORCPT ); Wed, 4 Mar 2015 04:03:38 -0500 X-Greylist: delayed 873 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Mar 2015 04:03:37 EST Message-ID: <54F6CA60.5030905@freescale.com> Date: Wed, 4 Mar 2015 11:03:28 +0200 From: Cristian Stoica User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: yjin , Kim Phillips CC: , , , , , , , Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings References: <1425365453-19358-1-git-send-email-yanjiang.jin@windriver.com> <1425365453-19358-2-git-send-email-yanjiang.jin@windriver.com> <20150303125953.8585904680288a9734566b42@freescale.com> <54F66EA3.7080506@windriver.com> <54F6909D.8040002@windriver.com> In-Reply-To: <54F6909D.8040002@windriver.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=cristian.stoica@freescale.com; windriver.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(377454003)(199003)(189002)(24454002)(479174004)(51444003)(36756003)(50986999)(54356999)(106466001)(65816999)(76176999)(87266999)(105606002)(87936001)(92566002)(62966003)(46102003)(77156002)(65956001)(77096005)(47776003)(104016003)(50466002)(83506001)(23676002)(33656002)(2950100001)(6806004)(93886004)(85426001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB392;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB392; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BLUPR03MB392;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB392; X-Forefront-PRVS: 0505147DDB X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2015 09:03:33.1161 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB392 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 06:57 AM, yjin wrote: > An alternative is moving the definitions to a ".c" file, but I don't > think it will be fundamental different. > I know I am fixing a potential error which doesn't exist now, it seems > useless for the current upstream version, we can abandon my patch. But I > still think the current implementation adds unnecessary restrictions for > its users. I think that both dma_map_sg_chained and dma_unmap_sg_chained should go away. They were added to support chained scatterlists, but as far as I verified, dma_map_sg should handle that case as well. Kim, can you confirm this? Cristian S.