From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933867AbbCDJMA (ORCPT ); Wed, 4 Mar 2015 04:12:00 -0500 Received: from mail-bl2on0119.outbound.protection.outlook.com ([65.55.169.119]:42240 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932801AbbCDJL5 (ORCPT ); Wed, 4 Mar 2015 04:11:57 -0500 Message-ID: <54F6CC54.6090203@freescale.com> Date: Wed, 4 Mar 2015 11:11:48 +0200 From: Cristian Stoica User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: yjin , Kim Phillips CC: , , , , , , , Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings References: <1425365453-19358-1-git-send-email-yanjiang.jin@windriver.com> <1425365453-19358-2-git-send-email-yanjiang.jin@windriver.com> <20150303125953.8585904680288a9734566b42@freescale.com> <54F66EA3.7080506@windriver.com> In-Reply-To: <54F66EA3.7080506@windriver.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=cristian.stoica@freescale.com; windriver.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(24454002)(377454003)(479174004)(189002)(199003)(51704005)(6806004)(87266999)(92566002)(50466002)(33656002)(2950100001)(46102003)(65816999)(77156002)(62966003)(77096005)(87936001)(93886004)(65956001)(106466001)(23676002)(47776003)(104016003)(54356999)(50986999)(19580405001)(105606002)(83506001)(36756003)(76176999)(85426001)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB390;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB390; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BLUPR03MB390;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB390; X-Forefront-PRVS: 0505147DDB X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2015 09:11:54.2061 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB390 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: > > On 2015年03月04日 02:59, Kim Phillips wrote: >> On Tue, 3 Mar 2015 14:50:51 +0800 >> wrote: >> >>> This commit is to avoid the below warnings: >>> >>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: >>> 'dma_map_sg_chained' defined but not used [-Wunused-function] >>> static int dma_map_sg_chained(struct device *dev, struct >>> scatterlist *sg, [...] > > We can find an example in Freescale SDK 1.6: > caampkc.c includes pkc_desc.h, pkc_desc.h includes sg_sw_sec4.h, but > caampkc.c doesn't call those functions. This one was fixed in sdk-1.7 with the following patch: diff --git a/drivers/crypto/caam/pkc_desc.h b/drivers/crypto/caam/pkc_desc.h index f73ad07..03013c2 100644 --- a/drivers/crypto/caam/pkc_desc.h +++ b/drivers/crypto/caam/pkc_desc.h @@ -20,7 +20,6 @@ #include "desc_constr.h" #include "jr.h" #include "error.h" -#include "sg_sw_sec4.h" #include #include "pdb.h" Cristian S.