From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Andy Gross <agross@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>,
Daniel Sneddon <dsneddon@codeaurora.org>
Subject: Re: [PATCH v3] spi: qup: Add DMA capabilities
Date: Wed, 04 Mar 2015 11:37:17 +0200 [thread overview]
Message-ID: <54F6D24D.2050509@linaro.org> (raw)
In-Reply-To: <1425458290.5705.2.camel@mm-sol.com>
On 03/04/2015 10:38 AM, Ivan T. Ivanov wrote:
>
> Hi Stan,
>
> It looks good now, except it doesn't apply and two small issues below:
>
<snip>
>
>> +
>> + /* set DMA parameters */
>> + rx_conf->direction = DMA_DEV_TO_MEM;
>> + rx_conf->device_fc = 1;
>
> Strictly speeching this is a bool not int.
sure will correct.
>>
>> + ret = spi_qup_init_dma(master, res->start);
>> + if (ret == -EPROBE_DEFER)
>> + goto error;
>> + else if (!ret)
>> + master->can_dma = spi_qup_can_dma;
>> +
>> /* set v1 flag if device is version 1 */
>> if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>> controller->qup_v1 = 1;
>
> It is not visible from this patch, but in case of error reseting
> SPI controller (QUP_STATE_RESET), exit error path should be
> 'error_dma' and not 'error' label.
my fault, will correct.
regards,
Stan
prev parent reply other threads:[~2015-03-04 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 16:58 [PATCH v3] spi: qup: Add DMA capabilities Stanimir Varbanov
2015-03-04 8:38 ` Ivan T. Ivanov
2015-03-04 9:37 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6D24D.2050509@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsneddon@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox