From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760678AbbCDJh1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 04:37:27 -0500
Received: from mail-wg0-f53.google.com ([74.125.82.53]:39064 "EHLO
	mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759191AbbCDJhY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 04:37:24 -0500
Message-ID: <54F6D24D.2050509@linaro.org>
Date: Wed, 04 Mar 2015 11:37:17 +0200
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5
MIME-Version: 1.0
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
CC: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Kumar Gala <galak@codeaurora.org>,
        Andy Gross <agross@codeaurora.org>,
        Sagar Dharia <sdharia@codeaurora.org>,
        Daniel Sneddon <dsneddon@codeaurora.org>
Subject: Re: [PATCH v3] spi: qup: Add DMA capabilities
References: <1425056312-13746-1-git-send-email-stanimir.varbanov@linaro.org> <1425458290.5705.2.camel@mm-sol.com>
In-Reply-To: <1425458290.5705.2.camel@mm-sol.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/04/2015 10:38 AM, Ivan T. Ivanov wrote:
> 
> Hi Stan,
> 
> It looks good now, except it doesn't apply and two small issues below:
> 

<snip>

> 
>> +
>> +       /* set DMA parameters */
>> +       rx_conf->direction = DMA_DEV_TO_MEM;
>> +       rx_conf->device_fc = 1;
> 
> Strictly speeching this is a bool not int.

sure will correct.

>>
>> +       ret = spi_qup_init_dma(master, res->start);
>> +       if (ret == -EPROBE_DEFER)
>> +               goto error;
>> +       else if (!ret)
>> +               master->can_dma = spi_qup_can_dma;
>> +
>>         /* set v1 flag if device is version 1 */
>>         if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>>                 controller->qup_v1 = 1;
> 
> It is not visible from this patch, but in case of error reseting
> SPI controller (QUP_STATE_RESET), exit error path should be 
> 'error_dma' and not 'error' label.

my fault, will correct.

regards,
Stan