From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761158AbbCDKM0 (ORCPT ); Wed, 4 Mar 2015 05:12:26 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:35335 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758482AbbCDKLU (ORCPT ); Wed, 4 Mar 2015 05:11:20 -0500 X-AuditID: cbfee691-f79b86d000004a5a-1f-54f6da46ca58 Message-id: <54F6DA45.2080508@samsung.com> Date: Wed, 04 Mar 2015 19:11:17 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Arnd Bergmann Cc: Chanwoo Choi , linux-arm-kernel , Mark Rutland , devicetree , linux-samsung-soc , Marc Zyngier , "catalin.marinas@arm.com" , Olof Johansson , "will.deacon@arm.com" , linux-kernel , "jh80.chung@samsung.com" , Seung-Woo Kim , Kukjin Kim , Abhilash Kesavan , "chanho61.park@samsung.com" , "inki.dae@samsung.com" , ideal.song@samsung.com Subject: Re: [PATCH v4 2/8] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC References: <1424755011-15999-1-git-send-email-cw00.choi@samsung.com> <13467157.nyRCsNWIp6@wuerfel> <54F6AD6B.70007@samsung.com> <2449954.zWisnqDpUA@wuerfel> In-reply-to: <2449954.zWisnqDpUA@wuerfel> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRsSkUNft1rcQg+ebOSwer1nMZPF30jF2 i/fLehgtLu/Xtnh2VNti/pFzrBa7/t5ntJh0fwKLxY1fbawW/Y9fM1tsenyN1eLyrjlsFjPO 7wPqvPOPzWLp9YtMFqeufwaKTX7JZvHy4wkWByGPNfPWMHr8/jWJ0WPnrLvsHptWdbJ5bF5S 73HlRBOrR9+WVYwenzfJBXBEcdmkpOZklqUW6dslcGV8OjKbqeAiX0X37G6mBsZN3F2MnBwS AiYSq5a9YoGwxSQu3FvP1sXIxSEksJRR4tLEK+wwRTd39bNDJKYzSpye0AzlvGaUeL3nEytI Fa+AlsTqU6fARrEIqEqcWL6IGcRmA4rvf3GDDcQWFQiTWDn9CgtEvaDEj8n3wGwRAUWJqS+e gdUzC3xhlZi+QQTEFhaIlHj4sxnqpIWMEhc+rQQbxCmgKTFj5UUWiAYdif2t09ggbHmJzWve MoM0SAis5JB4vuIHG8RFAhLfJh8CauAASshKbDrADPGapMTBFTdYJjCKzUJy0ywkY2chGbuA kXkVo2hqQXJBcVJ6kalecWJucWleul5yfu4mRmACOP3v2cQdjPcPWB9iFOBgVOLhzYj+FiLE mlhWXJl7iNEU6IqJzFKiyfnANJNXEm9obGZkYWpiamxkbmmmJM6rI/0zWEggPbEkNTs1tSC1 KL6oNCe1+BAjEwenVAPjevOSfV21u820j4pVdNa8rN+7ZeWHPiljt2IhgZOZywW++zWf3ee5 5a36lzWhrbZl2kkJpl5dqw0s1Netfa0zZ66A/csFvtVnHza5ri70Lj/FunrFI3PDgLo7WbJ8 Db4Rs0z8fu59/C0rIeK5igOPmrgKa12I4fVn3bqtmqVf1JnPS//v61RiKc5INNRiLipOBAC7 TMXH+wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jQV3XW99CDLbetLZ4vGYxk8XfScfY Ld4v62G0uLxf2+LZUW2L+UfOsVrs+nuf0WLS/QksFjd+tbFa9D9+zWyx6fE1VovLu+awWcw4 vw+o884/Noul1y8yWZy6/hkoNvklm8XLjydYHIQ81sxbw+jx+9ckRo+ds+6ye2xa1cnmsXlJ vceVE02sHn1bVjF6fN4kF8AR1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6k kJeYm2qr5OIToOuWmQP0ipJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx 49OR2UwFF/kqumd3MzUwbuLuYuTkkBAwkbi5q58dwhaTuHBvPVsXIxeHkMB0RonTE5rZIZzX jBKv93xiBaniFdCSWH3qFAuIzSKgKnFi+SJmEJsNKL7/xQ02EFtUIExi5fQrLBD1ghI/Jt8D s0UEFCWmvngGVs8s8IVVYvoGERBbWCBS4uHPZqjNCxklLnxaCTaIU0BTYsbKiywQDToS+1un sUHY8hKb17xlnsAoMAvJjllIymYhKVvAyLyKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIzi9 PJPewbiqweIQowAHoxIP74HYbyFCrIllxZW5hxglOJiVRHhjLwKFeFMSK6tSi/Lji0pzUosP MZoCg2Ais5Rocj4w9eWVxBsam5gZWRqZG1oYGZsrifMq2beFCAmkJ5akZqemFqQWwfQxcXBK NTDaeuVtnW7JHPlVPnTqib/+CnpndvR+DFWyfetirp1R/q9GUOdUWN+E7xcm5E797N/L0Za/ 48eruJXtu/0fyt94+N39HPcl86g/SgY3FW5aBxz/fd5RU2JHQvzGujWM3nWxkwJ3bv3qvmsa y65wxcRcxteWJgbthU+TRI4+LP++8Rz7rkkcn92UWIozEg21mIuKEwFIfGrJRQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 06:38 PM, Arnd Bergmann wrote: > On Wednesday 04 March 2015 15:59:55 Chanwoo Choi wrote: >> On 03/02/2015 06:22 AM, Arnd Bergmann wrote: >>> On Saturday 28 February 2015 09:47:01 Chanwoo Choi wrote: >>>> "earlycon=exynos4210,0x14C20000" is correct bootparam. You can check >>>> it on Documentation/kernel-parameters.txt as following. >>>> >>>> exynos4210, >>>> Use early console provided by serial driver available >>>> on Samsung SoCs, requires selecting proper type and >>>> a correct base address of the selected UART port. The >>>> serial port must already be setup and configured. >>>> Options are not yet supported. >>>> >>>> >>> >>> But it's crazy to do this when you have a DT. Please fix the existing >>> devicetree files that use this to just list 'earlycon'. >>> >>> The syntax above only makes sense for classic board files that we >>> do not support for exynos any more. >> >> Following earlycon patch for exynos soc was merged in Linux 4.0-rc1. >> - commit-id: b94ba0328d3b36ff95f5074c0e9b44f90dc56bb5 (serial: samsung: Add support for early console) >> Almost Exynos SoC use the same UART IP of Exynos4210. >> >> If you mean that "earlycon=exynos4210" naming will be changed to "earlycon=exynos", >> we have to modify the drivers/tty/serial/samsung.c. > > No, what I mean is that you should use just "earlycon" instead of "earlycon=..." > when you have a DTB. You have the OF_EARLYCON_DECLARE() in the driver as > well, so that should just work. > > EARLYCON_DECLARE() is really just a hack that allows users to override the > early console from the command line without modifying the stdout-path > property. Don't put that into a dts file. OK, I understand. Thanks for your comment. Regards, Chanwoo Choi