From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760100AbbCDKeg (ORCPT ); Wed, 4 Mar 2015 05:34:36 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:53368 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758148AbbCDKee (ORCPT ); Wed, 4 Mar 2015 05:34:34 -0500 X-IronPort-AV: E=Sophos;i="5.09,687,1418083200"; d="scan'208";a="241299226" Message-ID: <54F6DFB7.2080402@citrix.com> Date: Wed, 4 Mar 2015 10:34:31 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Tao Chen , , , CC: , , , , Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK References: <1425493951-41801-1-git-send-email-boby.chen@huawei.com> In-Reply-To: <1425493951-41801-1-git-send-email-boby.chen@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/15 18:32, Tao Chen wrote: > Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. > Also fixed up some comments just as eliminate redundant white spaces and format the code. > These will make the code easier to read. I have already said you needed to use: #define pr_fmt(fmt) to do this. David