From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758678AbbCDOhB (ORCPT ); Wed, 4 Mar 2015 09:37:01 -0500 Received: from mga09.intel.com ([134.134.136.24]:29532 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756819AbbCDOg7 (ORCPT ); Wed, 4 Mar 2015 09:36:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,687,1418112000"; d="scan'208";a="535981187" Message-ID: <54F71888.4040608@linux.intel.com> Date: Wed, 04 Mar 2015 06:36:56 -0800 From: Arjan van de Ven User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov CC: Ingo Molnar , "Li, Aubrey" , "alan@linux.intel.com" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len.Brown@intel.com, x86@kernel.org, LKML Subject: Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform References: <54F67ACC.3010500@linux.intel.com> <20150304050858.GB5158@gmail.com> <54F69774.2050400@linux.intel.com> <20150304053106.GA3701@gmail.com> <54F6A08B.2010105@linux.intel.com> <20150304073717.GA11736@gmail.com> <54F6C59C.706@linux.intel.com> <20150304095011.GH3233@pd.tnic> In-Reply-To: <20150304095011.GH3233@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/2015 1:50 AM, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 12:43:08AM -0800, Arjan van de Ven wrote: >>> >>> Using 'acpi_gbl_reduced_hardware' flag outside the ACPI code >>> is a mistake. >> >> ideally, the presence of that flag in the firmware table will clear/set more global settings, >> for example, having that flag should cause the 8042 input code to not probe for the 8042. >> >> for interrupts, there really ought to be a "apic first/only" mode, which is then used on >> all modern systems (not just hw reduced). > > Do we need some sort of platform-specific querying interfaces now too, > similar to cpu_has()? I.e., platform_has()... > > if (platform_has(X86_PLATFORM_REDUCED_HW)) > do stuff.. more like platform_has(X86_PLATFORM_PIT) etc, one for each legacy io item so we can clear it on hw reduced, but also in other cases. hw reduced is one way, but I'd be surprised if there weren't other ways (like quirks) where we'd want to do the same things