From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<paulmck@linux.vnet.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <mingo@kernel.org>,
<laijs@cn.fujitsu.com>, <dipankar@in.ibm.com>,
<akpm@linux-foundation.org>, <mathieu.desnoyers@efficios.com>,
<josh@joshtriplett.org>, <tglx@linutronix.de>,
<peterz@infradead.org>, <rostedt@goodmis.org>,
<dhowells@redhat.com>, <edumazet@google.com>,
<dvhart@linux.intel.com>, <fweisbec@gmail.com>, <oleg@redhat.com>,
<bobby.prani@gmail.com>, <x86@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH tip/core/rcu 02/20] x86: Use common outgoing-CPU-notification code
Date: Wed, 4 Mar 2015 15:45:21 +0000 [thread overview]
Message-ID: <54F72891.5070805@citrix.com> (raw)
In-Reply-To: <54F71CCF.9050509@oracle.com>
On 04/03/15 14:55, Boris Ostrovsky wrote:
>
> In the meantime, it turned out that HVM guests are broken by this patch
> (with our without changes that we've been discussing), because HVM CPUs
> die with
>
> static void xen_hvm_cpu_die(unsigned int cpu)
> {
> xen_cpu_die(cpu);
> native_cpu_die(cpu);
> }
>
> Which means that cpu_wait_death() is called twice, and second call moves
> the CPU to CPU_BROKEN.
>
> The simple solution is to stop calling native_cpu_die() above but I'd
> like to use common code in native_cpu_die(). I'll see if I can carve it
> out without too much damage to x86.
If not really been following this thread but...
Would it be preferable to refactor xen_cpu_die() instead to factor out
its the cpu_wait_death() call?
David
next prev parent reply other threads:[~2015-03-04 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 17:41 [PATCH tip/core/rcu 0/20] CPU hotplug updates for v4.1 Paul E. McKenney
2015-03-03 17:42 ` [PATCH tip/core/rcu 01/20] smpboot: Add common code for notification from dying CPU Paul E. McKenney
2015-03-03 17:42 ` [PATCH tip/core/rcu 02/20] x86: Use common outgoing-CPU-notification code Paul E. McKenney
2015-03-03 19:17 ` Boris Ostrovsky
2015-03-03 19:42 ` Paul E. McKenney
2015-03-03 20:13 ` Boris Ostrovsky
2015-03-03 21:26 ` Paul E. McKenney
2015-03-03 22:06 ` Boris Ostrovsky
2015-03-03 22:31 ` Paul E. McKenney
2015-03-04 14:43 ` Paul E. McKenney
2015-03-04 14:55 ` Boris Ostrovsky
2015-03-04 15:25 ` Paul E. McKenney
2015-03-05 21:17 ` Boris Ostrovsky
2015-03-05 22:00 ` Paul E. McKenney
2015-03-04 15:45 ` David Vrabel [this message]
2015-03-04 16:10 ` Boris Ostrovsky
2015-03-03 17:42 ` [PATCH tip/core/rcu 03/20] blackfin: " Paul E. McKenney
2015-03-03 17:42 ` [PATCH tip/core/rcu 04/20] metag: " Paul E. McKenney
2015-03-10 15:30 ` James Hogan
2015-03-10 16:59 ` Paul E. McKenney
2015-03-11 11:03 ` James Hogan
2015-03-11 18:58 ` Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 05/20] rcu: Consolidate offline-CPU callback initialization Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 06/20] rcu: Put all orphan-callback-related code under same comment Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 07/20] rcu: Simplify sync_rcu_preempt_exp_init() Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 08/20] rcu: Eliminate empty HOTPLUG_CPU ifdef Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 09/20] rcu: Detect stalls caused by failure to propagate up rcu_node tree Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 10/20] rcu: Provide diagnostic option to slow down grace-period initialization Paul E. McKenney
2015-03-04 10:54 ` Paul Bolle
2015-03-04 14:59 ` Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 11/20] rcutorture: Enable slow grace-period initializations Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 12/20] rcu: Remove event tracing from rcu_cpu_notify(), used by offline CPUs Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 13/20] rcu: Rework preemptible expedited bitmask handling Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 14/20] rcu: Move rcu_report_unblock_qs_rnp() to common code Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 15/20] rcu: Process offlining and onlining only at grace-period start Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 16/20] rcu: Eliminate ->onoff_mutex from rcu_node structure Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 17/20] cpu: Make CPU-offline idle-loop transition point more precise Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 18/20] rcu: Handle outgoing CPUs on exit from idle loop Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 19/20] rcutorture: Default to grace-period-initialization delays Paul E. McKenney
2015-03-03 17:43 ` [PATCH tip/core/rcu 20/20] rcu: Add diagnostics to grace-period cleanup Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F72891.5070805@citrix.com \
--to=david.vrabel@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=konrad.wilk@oracle.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox