From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759533AbbCDREm (ORCPT ); Wed, 4 Mar 2015 12:04:42 -0500 Received: from service87.mimecast.com ([91.220.42.44]:53001 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759153AbbCDREk convert rfc822-to-8bit (ORCPT ); Wed, 4 Mar 2015 12:04:40 -0500 Message-ID: <54F73B2B.3050305@arm.com> Date: Wed, 04 Mar 2015 17:04:43 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Laurent Pinchart CC: Sudeep Holla , Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id References: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com> <9376982.frUB33IUZX@avalon> <54F72B1C.2080700@arm.com> <38531734.64FvIzp7Ky@avalon> In-Reply-To: <38531734.64FvIzp7Ky@avalon> X-OriginalArrivalTime: 04 Mar 2015 17:04:36.0592 (UTC) FILETIME=[4B3D7F00:01D0569D] X-MC-Unique: 115030417043806701 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/15 16:11, Laurent Pinchart wrote: > Hi Sudeep, > > On Wednesday 04 March 2015 15:56:12 Sudeep Holla wrote: [...] >> >> Also I don't see any message on the host side. Let me know if there's >> something wrong in my config or test commands. > > Looks like a driver bug to me, .udc_start() and .udc_stop() should use > spin_(un)lock_irq(). Would you like to submit a patch ? I can also do it. > Thanks for the quick response. Yes I can submit that as I do have the patch already. Though it removes above dump for possible deadlock, it's still not working. So I was not sure if that's the right fix. Anyways I will post that patch and you can review :) BTW, if you see above the log also contains "g_mass_storage gadget: userspace failed to provide iSerialNumber". Is this OK ? or is this the reason for not seeing any activity on host side. Regards, Sudeep